Switch away from text_type shims.

 






 

 


  Review Request #11854
  —
  Created Oct. 15, 2021 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  master
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
In the Python 2 to 3 conversion, the name of the binary type was changed

from str to bytes, and the name of the string type was changed from

unicode to str. In addition, there were some other changes such as

the removal of the basestring type. The six library included a bunch

of helpers to ease this transition. Now that we're Python 3+ only on the

master branch, we can get rid of these and just use the builtins.

 








  


 
 

  
Ran unit tests.

 







 









 





  








 




 







   

    
    
Diff Revision 1 (Latest)



    

    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Switch away from text_type shims.
     
In the Python 2 to 3 conversion, the name of the binary type was changed
from `str` to `bytes`, and the name of the string type was changed from
`unicode` to `str`. In addition, there were some other changes such as
the removal of the `basestring` type. The `six` library included a bunch
of helpers to ease this transition. Now that we're Python 3+ only on the
master branch, we can get rid of these and just use the builtins.

Testing Done:
Ran unit tests.

    

   
  		
  d56c52cda00badbd1d7f1f1cb7ffcdae0e4d2343
  David Trowbridge
 




    


    
    

 This diff has been split across 5 pages:
 
  <
 
 
  
   1
  
 
  
   2
  
 
  
   3
  
 
  
   4
  
 
  
   5
  
 
 


   

  

 









 

  

   
    

     
      
      reviewboard/testing/scmtool.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/testing/testcase.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/base.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/resources/api_token.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/resources/base_comment.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/resources/base_review.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/resources/base_review_request_file_attachment.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/resources/base_screenshot.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/resources/diff.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/resources/draft_diffcommit.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/resources/hosting_service_account.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/resources/repository.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/resources/repository_branches.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/resources/repository_commits.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/resources/repository_info.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/resources/review.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/resources/review_reply.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/resources/review_request.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/resources/review_request_draft.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/resources/session.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/resources/user.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/resources/validate_diff.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/resources/validate_diffcommit.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/tests/base.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/tests/test_change.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/tests/test_default_reviewer.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/tests/test_review_request.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/tests/test_webhook.py
     
    

   
  

 





 This diff has been split across 5 pages:
 
  <
 
 
  
   1
  
 
  
   2
  
 
  
   3
  
 
  
   4
  
 
  
   5
  
 
 







     

    

   

  

  

   
   Loading...