Switch away from text_type shims.

Review Request #11854 — Created Oct. 15, 2021 and submitted — Latest diff uploaded

Information

Review Board
master

Reviewers

In the Python 2 to 3 conversion, the name of the binary type was changed
from str to bytes, and the name of the string type was changed from
unicode to str. In addition, there were some other changes such as
the removal of the basestring type. The six library included a bunch
of helpers to ease this transition. Now that we're Python 3+ only on the
master branch, we can get rid of these and just use the builtins.

Ran unit tests.

Diff Revision 1 (Latest)

Commits

First Last Summary ID Author
Switch away from text_type shims.
In the Python 2 to 3 conversion, the name of the binary type was changed from `str` to `bytes`, and the name of the string type was changed from `unicode` to `str`. In addition, there were some other changes such as the removal of the `basestring` type. The `six` library included a bunch of helpers to ease this transition. Now that we're Python 3+ only on the master branch, we can get rid of these and just use the builtins. Testing Done: Ran unit tests.
d56c52cda00badbd1d7f1f1cb7ffcdae0e4d2343 David Trowbridge
This diff has been split across 5 pages: 1 2 3 4 5 >
reviewboard/accounts/trophies.py
reviewboard/accounts/views.py
reviewboard/accounts/backends/ldap.py
reviewboard/admin/form_widgets.py
reviewboard/admin/server.py
reviewboard/admin/siteconfig.py
reviewboard/admin/widgets.py
reviewboard/admin/forms/change_form.py
reviewboard/admin/forms/email_settings.py
reviewboard/admin/templatetags/rbadmintags.py
reviewboard/admin/tests/test_dashboard_view.py
reviewboard/changedescs/models.py
reviewboard/cmdline/rbsite.py
reviewboard/cmdline/utils/console.py
reviewboard/datagrids/columns.py
reviewboard/datagrids/tests.py
reviewboard/diffviewer/chunk_generator.py
reviewboard/diffviewer/diffutils.py
reviewboard/diffviewer/parser.py
reviewboard/diffviewer/renderers.py
This diff has been split across 5 pages: 1 2 3 4 5 >
Loading...