• 
  
    
 
    
 
    

    



    
    
    
    
     
    




    
 
    

  
    



    
 

 

  

  

 

    


  
    





    
 
    



  

    
 
 
    
  
    Remove obsolete __future__ imports.
    
 
    

    



 
    
 
    

  Review Request #11851
  —
  Created Oct. 14, 2021 and submitted 

 
    


    




    




    






 
    
  
    
   Information

  
    



    
 
 
    
  david
 
    

    





    
 
 
    
  Review Board
 
    

    





    
 
 
    
  master
 
    

    





    
 
 
    
  
 
    

    





    
 
 
    
  
 
    

    



 
    



 
    
  
    
   Reviewers

  
    



    
 
 
    
  reviewboard
 
    

    





    
 
 
    
  
 
    

    



 
    



    


    
 
    




  

    
 
 
    
  
    Now that we're Python 3 only, we can remove all of the __future__
    
imports that we had added for compatibility. This change is mechanical
    
but quite large. It's been split up into individual commits for each
    
module for ease of review.
    
 
    

    





  

    
 
 
    
  
    Ran unit tests.
    
 
    

    




 
    

    





    
 
    




  
    
 
 
    
  


    
 
    
  
   
    

    Summary
    ID

   
    
      
  

   
    

    

     
    
      Remove obsolete __future__ imports from reviewboard.accounts.
      
    Now that we're Python 3 only, we can remove all of the `__future__`
imports that we had added for compatibility. This change does so for the
`reviewboard.accounts` module.

Testing Done:
Ran unit tests.
    
     
    

        		
    49ed04d24ec42be8f8aca5910d1ae7299f77365a

   
    

   
    

    

     
    
      Remove obsolete __future__ imports from reviewboard.admin.
      
    Now that we're Python 3 only, we can remove all of the `__future__`
imports that we had added for compatibility. This change does so for the
`reviewboard.admin` module.

Testing Done:
Ran unit tests.
    
     
    

        		
    836d20f61fb269245844348908f4bd32b5501fb8

   
    

   
    

    

     
    
      Remove obsolete __future__ imports from reviewboard.attachments.
      
    Now that we're Python 3 only, we can remove all of the `__future__`
imports that we had added for compatibility. This change does so for the
`reviewboard.attachments` module.

Testing Done:
Ran unit tests.
    
     
    

        		
    aec9243f61e9a3bdfae93d41ececf88afc110889

   
    

   
    

    

     
    
      Remove obsolete __future__ imports from reviewboard.avatars.
      
    Now that we're Python 3 only, we can remove all of the `__future__`
imports that we had added for compatibility. This change does so for the
`reviewboard.avatars` module.

Testing Done:
Ran unit tests.
    
     
    

        		
    d6714e6ebe82cfebda4c8239108ce9771ea19644

   
    

   
    

    

     
    
      Remove obsolete __future__ imports from reviewboard.changedescs.
      
    Now that we're Python 3 only, we can remove all of the `__future__`
imports that we had added for compatibility. This change does so for the
`reviewboard.changedescs` module.

Testing Done:
Ran unit tests.
    
     
    

        		
    4be04ef1d871fc72d9b465a58258e53066b53a07

   
    

   
    

    

     
    
      Remove obsolete __future__ imports from reviewboard.cmdline.
      
    Now that we're Python 3 only, we can remove all of the `__future__`
imports that we had added for compatibility. This change does so for the
`reviewboard.cmdline` module.

Testing Done:
Ran unit tests.
    
     
    

        		
    7812f0a8b40e63b7f853fd728d2723fc42bb60cf

   
    

   
    

    

     
    
      Remove obsolete __future__ imports from reviewboard.datagrids.
      
    Now that we're Python 3 only, we can remove all of the `__future__`
imports that we had added for compatibility. This change does so for the
`reviewboard.datagrids` module.

Testing Done:
Ran unit tests.
    
     
    

        		
    63e8b453c6862ea9d0ceddfa3971f4b75d2b8bf3

   
    

   
    

    

     
    
      Remove obsolete __future__ imports from reviewboard.diffviewer.
      
    Now that we're Python 3 only, we can remove all of the `__future__`
imports that we had added for compatibility. This change does so for the
`reviewboard.diffviewer` module.

Testing Done:
Ran unit tests.
    
     
    

        		
    44266ca4718acbec95a7c05641908414eb35c1ef

   
    

   
    

    

     
    
      Remove obsolete __future__ imports from reviewboard.extensions.
      
    Now that we're Python 3 only, we can remove all of the `__future__`
imports that we had added for compatibility. This change does so for the
`reviewboard.extensions` module.

Testing Done:
Ran unit tests.
    
     
    

        		
    ec287fd8375c55ec57351a20f3e2899642efdb10

   
    

   
    

    

     
    
      Remove obsolete __future__ imports from reviewboard.features.
      
    Now that we're Python 3 only, we can remove all of the `__future__`
imports that we had added for compatibility. This change does so for the
`reviewboard.features` module.

Testing Done:
Ran unit tests.
    
     
    

        		
    2fd0133a64509fb86157afba19599f26787db402

   
    

   
    

    

     
    
      Remove obsolete __future__ imports from reviewboard.hostingsvcs.
      
    Now that we're Python 3 only, we can remove all of the `__future__`
imports that we had added for compatibility. This change does so for the
`reviewboard.hostingsvcs` module.

Testing Done:
Ran unit tests.
    
     
    

        		
    3a11edfb5098c700ba60a06c18467606de37b330

   
    

   
    

    

     
    
      Remove obsolete __future__ imports from reviewboard.integrations.
      
    Now that we're Python 3 only, we can remove all of the `__future__`
imports that we had added for compatibility. This change does so for the
`reviewboard.integrations` module.

Testing Done:
Ran unit tests.
    
     
    

        		
    1eb61c78a2c3456142d2c4f8a4afd0d99bee440f

   
    

   
    

    

     
    
      Remove obsolete __future__ imports from reviewboard.notifications.
      
    Now that we're Python 3 only, we can remove all of the `__future__`
imports that we had added for compatibility. This change does so for the
`reviewboard.notifications` module.

Testing Done:
Ran unit tests.
    
     
    

        		
    38c8957e5b203285eae1b2acfb2698926ed0e8e2

   
    

   
    

    

     
    
      Remove obsolete __future__ imports from reviewboard.oauth.
      
    Now that we're Python 3 only, we can remove all of the `__future__`
imports that we had added for compatibility. This change does so for the
`reviewboard.oauth` module.

Testing Done:
Ran unit tests.
    
     
    

        		
    5ac6657e18fccbf3278284558e0c34d9a4d17728

   
    

   
    

    

     
    
      Remove obsolete __future__ imports from reviewboard.registries.
      
    Now that we're Python 3 only, we can remove all of the `__future__`
imports that we had added for compatibility. This change does so for the
`reviewboard.registries` module.

Testing Done:
Ran unit tests.
    
     
    

        		
    bd57bafc54350287a02a0f94496b0c733e332634

   
    

   
    

    

     
    
      Remove obsolete __future__ imports from reviewboard.reviews.
      
    Now that we're Python 3 only, we can remove all of the `__future__`
imports that we had added for compatibility. This change does so for the
`reviewboard.reviews` module.

Testing Done:
Ran unit tests.
    
     
    

        		
    4c63249980a428f4c28f8f88ec1c65a94866c9a5

   
    

   
    

    

     
    
      Remove obsolete __future__ imports from reviewboard.scmtools.
      
    Now that we're Python 3 only, we can remove all of the `__future__`
imports that we had added for compatibility. This change does so for the
`reviewboard.scmtools` module.

Testing Done:
Ran unit tests.
    
     
    

        		
    fa2a9b8fb12e764717802bc6b06e2f5a4f62dbbb

   
    

   
    

    

     
    
      Remove obsolete __future__ imports from reviewboard.search.
      
    Now that we're Python 3 only, we can remove all of the `__future__`
imports that we had added for compatibility. This change does so for the
`reviewboard.search` module.

Testing Done:
Ran unit tests.
    
     
    

        		
    687cf5f2430da6820774da6dfccacbd559c026e9

   
    

   
    

    

     
    
      Remove obsolete __future__ imports from reviewboard.site.
      
    Now that we're Python 3 only, we can remove all of the `__future__`
imports that we had added for compatibility. This change does so for the
`reviewboard.site` module.

Testing Done:
Ran unit tests.
    
     
    

        		
    077c66152d2626a38aa9997894bdbd24c44e943b

   
    

   
    

    

     
    
      Remove obsolete __future__ imports from reviewboard.ssh.
      
    Now that we're Python 3 only, we can remove all of the `__future__`
imports that we had added for compatibility. This change does so for the
`reviewboard.ssh` module.

Testing Done:
Ran unit tests.
    
     
    

        		
    b941de6a465d2cea2f5297007fe6a83e3e591417

   
    

   
    

    

     
    
      Remove obsolete __future__ imports from reviewboard.testing.
      
    Now that we're Python 3 only, we can remove all of the `__future__`
imports that we had added for compatibility. This change does so for the
`reviewboard.testing` module.

Testing Done:
Ran unit tests.
    
     
    

        		
    9b323e6ec1e46e26c5d44ea2f178db770f18e8f4

   
    

   
    

    

     
    
      Remove obsolete __future__ imports from reviewboard.webapi.
      
    Now that we're Python 3 only, we can remove all of the `__future__`
imports that we had added for compatibility. This change does so for the
`reviewboard.webapi` module.

Testing Done:
Ran unit tests.
    
     
    

        		
    eac601a577ea685d794b9a6527d41df4acd04c4b

   
    

   
    

    

     
    
      Remove obsolete __future__ imports from reviewboard.
      
    Now that we're Python 3 only, we can remove all of the `__future__`
imports that we had added for compatibility. This change does so for the
`reviewboard` module.

Testing Done:
Ran unit tests.
    
     
    

        		
    754dff83549c60ff1ac6de17f6bf8f86249f37ed

   
    


      
 
    

    
    
 
    

    






 





    
 
 
 
    
  
    
   
    
    
    
     
    
    
    
      
     
    • 
      
     
      • 
     
    • 
      
     
      • 
     
    • 
      
     
      • 
     
    • 
      
     
      • 
     
    • 
      
     
      • 
    
    
   
    
   
    
    
     
    
      Description
      From
      Last Updated
     
    
        
    



     
    
      
       
       
    Too many blank lines.
    
          		
      
       chipx86chipx86
      
      
       
      
     
    



     
    
      
       
       
    Too many blank lines.
    
          		
      
       chipx86chipx86
      
      
       
      
     
    

        
   
    
  
    
 
    

    




 
    

    



  
    
 
    

    


    












    
 




 

    


 













    
 





 
    
  
    
   
    



chipx86




   
    
   
    







    
  
    
 
    


 
    
  
    

   
    
   
    
    
     
chipx86


    
    
   
    

  
    
  
    
  
    


      




    1. 
 
      
  
      
   
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      2. 

















    2. 
 
      
  
  
      
  
 
      
  
      
   
      
    
     
      
      
       reviewboard/__init__.py
       


        (Diff revision 1)


       
      
     
      
          
    
     
       
      

     
       
      

     
       
      

     
       
      

     
       
      

     
       
      

     
       
      

          
   
      
  
      
 
      

   
      
    
    




      
 
      
  
  
  

  
  
   Show all issues
  
 
      

      



    
      Too many blank lines.
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      3. 






    3. 
 
      
  
  
      
  
 
      
  
      
   
      
    
     
      
      
       reviewboard/site/conditions.py
       


        (Diff revision 1)


       
      
     
      
          
    
     
       
      

     
       
      

          
   
      
  
      
 
      

   
      
    
    




      
 
      
  
  
  

  
  
   Show all issues
  
 
      

      



    
      Too many blank lines.
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      4. 




    4. 
 
      
  
      
   
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      5. 


    

  
    
 
    

    












    
 



 
    
  
    
   
    



david




   
    
   
    
  
    
 
    


 
    
  
    

   
    
   
    
    
     Review request changed
    
    
   
    

  
    
  
    
  
    




    

  
    
   
    
    Status:
   
    
   
    

    Completed

   
    
  
    



  
    
   
    
    Change Summary:
   
    
   
    
    
    Pushed to release-5.0.x (bd30dc5)