Switch away from iteration shims.

 






 

 


  Review Request #11850
  —
  Created Oct. 14, 2021 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  master
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
In the Python 2 to 3 conversion, many iteration methods (such as

items() and keys() were changed from returning lists to iterators.

In order to be correct in usage everywhere, we used six to ensure

consistent behavior across versions. Now that we're Python 3+ only on

the master branch, we can get rid of these and just use the builtins.

 








  


 
 

  
Ran unit tests.

 







 









 





  








 




 







   

    
    
Changes between revision 2 and 3



    

 

 

 

 
orig
1
2
3

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    

     Switch away from iteration shims.
     
In the Python 2 to 3 conversion, many iteration methods (such as
`items()` and `keys()` were changed from returning lists to iterators.
In order to be correct in usage everywhere, we used `six` to ensure
consistent behavior across versions. Now that we're Python 3+ only on
the master branch, we can get rid of these and just use the builtins.

Testing Done:
Ran unit tests.

    

   
  		
  e34930e1d86f0583885892d739ad06629088accb
  David Trowbridge
 


 
  
 
 
  
   
    

     Switch away from iteration shims.
     
In the Python 2 to 3 conversion, many iteration methods (such as
`items()` and `keys()` were changed from returning lists to iterators.
In order to be correct in usage everywhere, we used `six` to ensure
consistent behavior across versions. Now that we're Python 3+ only on
the master branch, we can get rid of these and just use the builtins.

Testing Done:
Ran unit tests.

    

   
  		
  e62db00a4e531d577797df057de1f85ab4f67d1a
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/accounts/backends/standard.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/avatars/templatetags/avatars.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/diffviewer/tests/test_commit_utils.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/reviews/builtin_fields.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...