Switch away from iteration shims.
Review Request #11850 — Created Oct. 14, 2021 and submitted — Latest diff uploaded
In the Python 2 to 3 conversion, many iteration methods (such as
items()andkeys()were changed from returning lists to iterators.
In order to be correct in usage everywhere, we usedsixto ensure
consistent behavior across versions. Now that we're Python 3+ only on
the master branch, we can get rid of these and just use the builtins.
Ran unit tests.
Diff Revision 2
This is not the most recent revision of the diff. The latest diff is revision 3. See what's changed.
orig
1
2
3
Commits
Files
| contrib/internal/prepare-dev.py |
|---|
| contrib/internal/webapi-lint.py |
|---|
| reviewboard/tests.py |
|---|
| reviewboard/accounts/backends/standard.py |
|---|
| reviewboard/admin/security_checks.py |
|---|
| reviewboard/admin/forms/auth_settings.py |
|---|
| reviewboard/admin/forms/general_settings.py |
|---|
| reviewboard/admin/management/sites.py |
|---|
| reviewboard/avatars/services.py |
|---|
| reviewboard/avatars/templatetags/avatars.py |
|---|
| reviewboard/cmdline/rbsite.py |
|---|
| reviewboard/cmdline/tests/test_rbsite.py |
|---|
| reviewboard/datagrids/sidebar.py |
|---|
| reviewboard/diffviewer/diffutils.py |
|---|
| reviewboard/diffviewer/opcode_generator.py |
|---|
| reviewboard/diffviewer/parser.py |
|---|
| reviewboard/diffviewer/models/diffset.py |
|---|
| reviewboard/diffviewer/models/filediff.py |
|---|
| reviewboard/diffviewer/tests/test_commit_utils.py |
|---|
| reviewboard/diffviewer/tests/test_filediff.py |
|---|