Fix downloading patch reject bundles on Python 3.

Review Request #11847 — Created Oct. 12, 2021 and discarded

Information

Review Board
release-4.0.x

Reviewers

Patch reject bundle zip files were being written to a StringIO, which
uses native strings. This failed on Python 3.

Bundles are now written to a BytesIO. Unit tests were updated to
ensure this works correctly on Python 2 and 3, and won't regress in the
future.

Unit tests pass on Python 2 and 3.

Manually verified the fix on Python 3.

Summary ID
Fix downloading patch reject bundles on Python 3.
Patch reject bundle zip files were being written to a `StringIO`, which uses native strings. This failed on Python 3. Bundles are now written to a `BytesIO`. Unit tests were updated to ensure this works correctly on Python 2 and 3, and won't regress in the future.
3afbd06e850d533196a008afabda43d915ed1003
david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Discarded