flake8
passed.
JSHint
passed.
Replacing non-named usages to use names logging for files in reviewboard.scmTools
Review Request #11817 — Created Sept. 18, 2021 and submitted
Only some logging statements in the scmtools module used named
logging, when all of them should. So all logging statements were given
the name "logger", and that was used instead.
Passed all unit tests.
| Summary | ID | Author |
|---|---|---|
| 9afa55142db0ce6576033ee4e287f8fe4c6ac21b | Your Name | |
| 24ba26a697ae791bd2ab645c6e5a74aed1e77fb0 | Your Name |
| Description | From | Last Updated |
|---|---|---|
|
For the summary, the module name needs to be all lowercase. |
 chipx86
|
|
|
For the description, this needs to wrap at around 75 characters, in order to fit properly in the Git commit … |
chipx86
|
|
|
This will need some testing. At the very least, you should run unit tests. |
chipx86
|
|
|
At the top-level of modules, there should always be 2 blank lines between sections. Imports are one section. Functions or … |
chipx86
|
|
|
The parameters no longer align. logger is one character shorter than logging, but the other line in this statement wasn't … |
chipx86
|
|
|
This will need 2 blank lines on both sides of logger = .... Can you go through the other files … |
chipx86
|
-
-
-
For the description, this needs to wrap at around 75 characters, in order to fit properly in the Git commit message.
-
-
At the top-level of modules, there should always be 2 blank lines between sections. Imports are one section. Functions or classes are each their own section. A group of related constants or variable declarations are a section.
So this would need to have 2 blank lines on both sides of it.
On top of that, this is being declared in the middle of the import section (see the
import ntpathbelow). You'll instead want this to be in its own section above the_cleartool = None. -
The parameters no longer align.
loggeris one character shorter thanlogging, but the other line in this statement wasn't similarly reduced by 1 character.This applies to other similar lines throughout the change. Can you go through the diff and check?
-
This will need 2 blank lines on both sides of
logger = ....Can you go through the other files and make sure the
loggerdeclaration section is following the 2 blank line rule?
- Summary:
-
Replacing non-named usages to use names logging for files in reviewboard.SCMToolsReplacing non-named usages to use names logging for files in reviewboard.scmTools
- Description:
-
~ Only some logging statements in the SCMTools module used named logging, when all of them should. So all logging statements were given the name "logger", and that was used instead.
~ Only some logging statements in the scmtools module used named
+ logging, when all of them should. So all logging statements were given + the name "logger", and that was used instead. - Testing Done:
-
~ Not tested
~ Passed all unit tests.
- Commits:
-
Summary ID Author 9afa55142db0ce6576033ee4e287f8fe4c6ac21b Your Name 9afa55142db0ce6576033ee4e287f8fe4c6ac21b Your Name 24ba26a697ae791bd2ab645c6e5a74aed1e77fb0 Your Name
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
