Fish Trophy

  
maubin got a fish trophy!

  
  Fish Trophy

 







 





 

 

  

  

 




  







 




  


 
 

  
Replace non-named logging with named logging for reviewboard.diffviewer

 






 

 


  Review Request #11811
  —
  Created Sept. 17, 2021 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  maubin
 









 
 

  Review Board
 









 
 

  release-4.0.x
 









 
 

  4903
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
While reviewboard.diffviewer already uses some named logging, this commit 

replaces all other usages of non-named logging with named logging instead.


Switching to named logging allows the logging mechanism to automatically 

include information about the module and where the logging message came 

from.

 








  


 
 

  
Ran unit tests for reviewboard.diffviewer and passed all tests.

 







 









 





  








 




 







   

    
    
Diff Revision 2 (Latest)



    

 

 

 

 
orig
1
2

 



    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Replace non-named logging with named logging for reviewboard.diffview
     
While reviewboard.diffview already uses some named logging, this commit replaces all other usages of non-named logging with named logging instead.
Switching to named logging allows the logging mechanism to automatically include information about the module and where the logging message came from.

    

   
  		
  275c6085f9a108507279031e5bdec98153dab828
  Michelle
 


 
  
   
  
  
   
  
 
 
  
   
    

     Fixed formatting issues
     
Added two blank lines around the loggers instance declarations
to denote that it is a separate section

Removed extra spaces which were making attribute values in logging
functions no longer line up with the other attributes

    

   
  		
  b20c33b0f96792e529278d19ae9d319599285015
  Michelle
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/diffviewer/diffutils.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/diffviewer/views.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...