Summary

Improve the error for unexpected function call spies in operations.

Review Request #11798 — Created Aug. 20, 2021 and submitted Aug. 24, 2021, 4:59 p.m.

Information

Owner

chipx86

Repository

kgb

Branch

master

Bugs

Depends On

Reviewers

Groups

kgb

People

Description

In match-based spy operations, exceptions are raised when a call is made
to a spy that either exceeds or doesn't match the list of expected
calls.

To help with debugging these situations, the exception now includes the
call that triggered the exception.

This uncovered an issue in SpyCall.__repr__ where a ) was missing
near the end of the string.

Testing Done

Unit tests pass on Python 2 and 3.

Commits

Summary	ID
Improve the error for unexpected function call spies in operations. In match-based spy operations, exceptions are raised when a call is made to a spy that either exceeds or doesn't match the list of expected calls. To help with debugging these situations, the exception now includes the call that triggered the exception. This uncovered an issue in `SpyCall.__repr__` where a `)` was missing near the end of the string.	a12455929d5fa328f8f0075c5eee014d9d587835

Summary

Improve the error for unexpected function call spies in operations.

In match-based spy operations, exceptions are raised when a call is made to a spy that either exceeds or doesn't match the list of expected calls. To help with debugging these situations, the exception now includes the call that triggered the exception. This uncovered an issue in `SpyCall.__repr__` where a `)` was missing near the end of the string.

a12455929d5fa328f8f0075c5eee014d9d587835

flake8 passed.

JSHint passed.

Change Summary:

Added the missing unit test update.

Commits:

	Summary	ID
	Improve the error for unexpected function call spies in operations. In match-based spy operations, exceptions are raised when a call is made to a spy that either exceeds or doesn't match the list of expected calls. To help with debugging these situations, the exception now includes the call that triggered the exception. This uncovered an issue in `SpyCall.__repr__` where a `)` was missing near the end of the string.	dec9bedfd3f5500e698f1f5245f9e0d0dc9c02de
	Improve the error for unexpected function call spies in operations. In match-based spy operations, exceptions are raised when a call is made to a spy that either exceeds or doesn't match the list of expected calls. To help with debugging these situations, the exception now includes the call that triggered the exception. This uncovered an issue in `SpyCall.__repr__` where a `)` was missing near the end of the string.	a12455929d5fa328f8f0075c5eee014d9d587835

Diff:

Revision 2 (+14 -6)

Show changes

	kgb/calls.py
	kgb/ops.py
	kgb/tests/test_ops.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (44a5220)