Summary

Fix pending/update changeset behavior.

Review Request #11795 — Created Aug. 16, 2021 and submitted Sept. 30, 2021, 3:17 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Commit

dbd0725...

Reviewers

Groups

reviewboard

People

Description

ReviewRequest.changeset_is_pending was broken when we did some changes
to the repository/scmtool API, because we neglected to replace the call
to get_scmtool(). This wasn't caught by our existing unit test because
the test was broken in a couple ways (it wasn't properly setting
supports_pending_changesets on the SCMTool class, and the check for
the new commit ID was overwriting the old value and then testing a
variable against itself).

Testing Done

Ran the fixed unit test and saw it fail. Applied the fix and saw all
unit tests succeed.

Issues

Description	From	Last Updated
This is going to leak to other tests. We need to try/finally this and restore the value, or, ideally, use …	chipx86	Sept. 3, 2021, 10:54 a.m.

flake8 passed.

JSHint passed.

reviewboard/reviews/tests/test_review_request.py (Diff revision 1)

The issue has been resolved. Show all issues

This is going to leak to other tests. We need to try/finally this and restore the value, or, ideally, use reviewboard.testing.scmtool.TestToolSupportsPendingChangeSets

Commit:

b083fd868f679c456ae7b15a24efc72c8dfaffa7

dbd072557ad0e6f3e19c3ceeb62faa63c8248dd0

Diff:

Revision 2 (+18 -5)

Show changes

	reviewboard/reviews/models/review_request.py
	reviewboard/reviews/tests/test_review_request.py
	reviewboard/scmtools/fixtures/test_scmtools.json
	reviewboard/testing/scmtool.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-4.0.x (550daa4)