Allow the version to be set during DiffX construction.

 






 

 


  Review Request #11761
  —
  Created July 31, 2021 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  chipx86
 









 
 

  DiffX
 









 
 

  master
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  diffx
 









 
 

  
 






 








 





  


 
 

  
The DiffX object now allows the version option to be set. This is

important for consumers that need to construct this object based on

existing data.


Only supported versions can be set. Unsupported versions will result in

an error.

 








  


 
 

  
Unit tests pass.


Ran into this with Review Board's implementation. Verified this fixed

the object construction.

 







 









 





  








 




 







   

    
    
Diff Revision 1 (Latest)



    

    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Allow the version to be set during DiffX construction.
     
The `DiffX` object now allows the `version` option to be set. This is
important for consumers that need to construct this object based on
existing data.

Only supported versions can be set. Unsupported versions will result in
an error.

    

   
  		
  d71f4921041026681f83d89fdac4449fa2661701
  Christian Hammond
 




    


    
    

   

  

 









 

  

   
    

     
      
      python/pydiffx/dom/objects.py
     
    

   
  

 



 

  

   
    

     
      
      python/pydiffx/dom/properties.py
     
    

   
  

 



 

  

   
    

     
      
      python/pydiffx/tests/test_dom_objects.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...