• 
      

    Fix regressions in Download Diffs and Perforce unit tests.

    Review Request #11746 — Created July 27, 2021 and submitted

    Information

    Review Board
    release-4.0.x

    Reviewers

    We've had some broken tests recently, one of which was a regressions
    from a merge, and the other a regression from potentially OpenSSL,
    stunnel, or Perforce.

    The first regression in the Download Diffs view was due to an old import
    location for TestService. We now import from the correct place.

    The second had to do with Perforce and stunnel. This might be
    system-dependent, but locally, all the stunnel unit tests started
    failing. Upon investigation, OpenSSL was complaining about the test
    certificate we use for the stunnel proxy. Potentially, it was due to a
    security issue present in the old certificate (length or cipher or
    something). Generating a brand-new certificate appears to solve this
    problem.

    Unit tests pass.

    Summary ID
    Fix regressions in Download Diffs and Perforce unit tests.
    We've had some broken tests recently, one of which was a regressions from a merge, and the other a regression from potentially OpenSSL, stunnel, or Perforce. The first regression in the Download Diffs view was due to an old import location for `TestService`. We now import from the correct place. The second had to do with Perforce and stunnel. This might be system-dependent, but locally, all the stunnel unit tests started failing. Upon investigation, OpenSSL was complaining about the test certificate we use for the stunnel proxy. Potentially, it was due to a security issue present in the old certificate (length or cipher or something). Generating a brand-new certificate appears to solve this problem.
    28b781f586c6093960556668f8843f6efc9829c1
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-4.0.x (f7f6c74)