Add a utility function for returning encoded newlines for a type.

 






 

 


  Review Request #11742
  —
  Created July 23, 2021 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  chipx86
 









 
 

  DiffX
 









 
 

  master
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  diffx
 









 
 

  
 






 








 





  


 
 

  
This introduces get_newline_for_type(), a utility function that takes

a LineEndings type value and returns newlines encoded as either ASCII

or the given encoding (with BOM stripped).


This logic was previously contained in DiffXReader, but is generally

useful, so it's being split out. That simplifies the DiffXReader code

as well, making some of the logic a lot more clear.

 








  


 
 

  
Unit tests pass on Python 2 and 3.

 







 









 





  








 




 







   

    
    
Diff Revision 1 (Latest)



    

    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Add a utility function for returning encoded newlines for a type.
     
This introduces `get_newline_for_type()`, a utility function that takes
a `LineEndings` type value and returns newlines encoded as either ASCII
or the given encoding (with BOM stripped).

This logic was previously contained in `DiffXReader`, but is generally
useful, so it's being split out. That simplifies the `DiffXReader` code
as well, making some of the logic a lot more clear.

    

   
  		
  1245d7bec05ef7ad783c64e1cf9a807ba91e6dd7
  Christian Hammond
 




    


    
    

   

  

 









 

  

   
    

     
      
      python/pydiffx/reader.py
     
    

   
  

 



 

  

   
    

     
      
      python/pydiffx/utils/text.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...