• 
      

    Fix a regression in loading commits in the New Review Request page.

    Review Request #11726 — Created July 15, 2021 and submitted

    Information

    Review Board
    release-4.0.x

    Reviewers

    In Review Board 4.0.3, changes were made to the commits list in the New
    Review Request page to load enough commits to fill up the scroll area.
    However, this change introduced a regression at the tail end of
    development, where a variable was renamed but the old name was checked.
    This prevented commits from loading indefinitely.

    This change fixes that issue, updating the variable name check and
    ensuring commits can continue to load.

    Tested loading commits in the New Review Request page. I was able to
    scroll as long as I wanted, with new commits continuing to load in.

    Summary ID
    Fix a regression in loading commits in the New Review Request page.
    In Review Board 4.0.3, changes were made to the commits list in the New Review Request page to load enough commits to fill up the scroll area. However, this change introduced a regression at the tail end of development, where a variable was renamed but the old name was checked. This prevented commits from loading indefinitely. This change fixes that issue, updating the variable name check and ensuring commits can continue to load.
    563dbfd69d66dc194c8479c59a79a5429a96ed55
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-4.0.x (d3a17b1)