Summary

Fix a regression in Subversion diff parsing.

Review Request #11724 — Created July 15, 2021 and submitted July 16, 2021, 1:19 a.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

A recent change intended to fix a deleted files indicator in Subversion
diffs regressed some parsing. We weren't checking whether the field in
question was None. This actually impacted a unit test, but it seems we
missed it (as CI is temporarily busted).

This change adds the necessary bullet-proofing, fixing the test.

Testing Done

Applicable unit tests pass.

Tested with a customer.

Commits

Summary	ID
Fix a regression in Subversion diff parsing. A recent change intended to fix a deleted files indicator in Subversion diffs regressed some parsing. We weren't checking whether the field in question was `None`. This actually impacted a unit test, but it seems we missed it (as CI is temporarily busted). This change adds the necessary bullet-proofing, fixing the test.	9482edca9d63a638597eb498ebef187bcdcb278b

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-4.0.x (e18d3b6)