Fix BaseRepositorySubForm to use new name for adding field prefixes.

 






 

 


  Review Request #11719
  —
  Created July 15, 2021 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  release-4.0.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
In 1.11, Django renamed Form.addprefix to Form.add_prefix. When we

updated to it, we never made the change, and so the repository forms

were still calling the old function. This didn't affect any of the

built-in SCMTools, but for third-party tools that want to prefix keys

into the extra_data, it was failing.

 








  


 
 

  
Used in conjunction with an external SCMTool.

 







 









 





  








 




 







   

    
    
Diff Revision 1 (Latest)



    

    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Fix BaseRepositorySubForm to use new name for adding field prefixes.
     
In 1.11, Django renamed `Form.addprefix` to `Form.add_prefix`. When we
updated to it, we never made the change, and so the repository forms
were still calling the old function. This didn't affect any of the
built-in SCMTools, but for third-party tools that want to prefix keys
into the extra_data, it was failing.

Testing Done:
Used in conjunction with an external SCMTool.

    

   
  		
  59477e0d2423c95b16ec00b12ded2f36c17ba3d9
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/scmtools/forms.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...