Summary

Allow repository-id to be used as a parameter instead of repository-path

Review Request #1166 — Created Oct. 7, 2009 and discarded

Information

Owner

rlynch

Repository

RBTools

Branch

Bugs

1338

Depends On

Reviewers

Groups

rbtools

People

Description

In my environment we are using a feature of Perforce which allows you to
redirect all requests through a remote server and also utilizing an
authorization key.  This causes the P4PORT setting to be different for
everyone and thus making it not match the repository-path on the
review-board server. This change allows for the rbtools to utilize a
repository-id in the new review request post call. The repository-id is
already supported by review-board.

Testing Done

Tested by created a new review request in my environment.

rbtools/postreview.py (Diff revision 1)
```
Blank line between these.
```

rbtools/postreview.py (Diff revision 1)

Please make sure this wraps to 80 characters.

rbtools/postreview.py (Diff revision 1)
```
Should be --repository-id
```

rbtools/postreview.py (Diff revision 1)

I'd prefer something more simple, like:

"the ID of the repository that the diff is generated from"

Also, it would be really nice to update the docs in the reviewboard tree (docs/manual/users/tools/post-review.txt).

Change Summary:

Updated based upon Christian Hammonds recommendations.

Diff:

Revision 2 (+15 -3)

Show changes

rbtools/postreview.py