Summary

Document and ensure legacy HostingServiceClient.json_*() result types.

Review Request #11645 — Created June 3, 2021 and submitted June 9, 2021, 1:04 a.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This updates the documentation for the HostingServiceClient.json_*()

methods (json_post(), json_get(), json_delete()) to specifically

say that header keys/values are native strings.
It also adds unit tests that guarantee this as well. While here, some

issues with existing unit tests were also fixed.
This will help with ensuring proper usage without any confusion over

types.

Testing Done

Unit tests passed on Python 2 and 3.

Commits

Summary	ID
Document and ensure legacy HostingServiceClient.json_() result types. This updates the documentation for the `HostingServiceClient.json_`() methods (`json_post()`, `json_get()`, `json_delete()`) to specifically say that header keys/values are native strings. It also adds unit tests that guarantee this as well. While here, some issues with existing unit tests were also fixed. This will help with ensuring proper usage without any confusion over types.	a06084f34d432f00bd883bdc7f7c2040e885f719

Summary

Document and ensure legacy HostingServiceClient.json_*() result types.

This updates the documentation for the `HostingServiceClient.json_*`() methods (`json_post()`, `json_get()`, `json_delete()`) to specifically say that header keys/values are native strings. It also adds unit tests that guarantee this as well. While here, some issues with existing unit tests were also fixed. This will help with ensuring proper usage without any confusion over types.

a06084f34d432f00bd883bdc7f7c2040e885f719

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-4.0.x (cbe0119)