Convert BaseResource.save to return a promise.

 






 

 


  Review Request #11642
  —
  Created June 2, 2021 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  master
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
This change updates the save machinery for various resources to use

promises and async/await instead of callbacks.

 








  


 
 

  
    

  • Ran js-tests.
    • 

  • Manually tested API token creation, comment editing, review request
    
  field editing, post-commit review request creation, ship-it revocation,
    
  and file attachment uploading.
    • 


 







 









 





  








 




 







   

    
    
Changes between revision 3 and 4



    

 

 

 

 
orig
1
2
3
4
5

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    

     Convert BaseResource.save to return a promise.
     
This change updates the save machinery for various resources to use
promises and async/await instead of callbacks.

Testing Done:
- Ran js-tests.
- Manually tested API token creation, comment editing, review request
  field editing, post-commit review request creation, ship-it revocation,
  and file attachment uploading.

    

   
  		
  2a68656268cbc391c8a76116055c98b34de93d28
  David Trowbridge
 


 
  
 
 
  
   
    

     Convert BaseResource.save to return a promise.
     
This change updates the save machinery for various resources to use
promises and async/await instead of callbacks.

Testing Done:
- Ran js-tests.
- Manually tested API token creation, comment editing, review request
  field editing, post-commit review request creation, ship-it revocation,
  and file attachment uploading.

    

   
  		
  3a7c5d1c2b30161af04cc48196b0a352156dac62
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/static/rb/js/models/tests/commentEditorModelTests.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/models/tests/reviewRequestEditorModelTests.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/resources/models/reviewRequestModel.es6.js
     
    

   
  

 










     

    

   

  

  

   
   Loading...