Convert BaseResource.save to return a promise.
Review Request #11642 — Created June 2, 2021 and submitted — Latest diff uploaded
This change updates the save machinery for various resources to use
promises and async/await instead of callbacks.
- Ran js-tests.
- Manually tested API token creation, comment editing, review request
field editing, post-commit review request creation, ship-it revocation,
and file attachment uploading.
Diff Revision 3
This is not the most recent revision of the diff. The latest diff is revision 5. See what's changed.
orig
1
2
3
4
5
Commits
Files
| reviewboard/static/rb/js/accountPrefsPage/views/apiTokensView.es6.js |
|---|
| reviewboard/static/rb/js/models/commentEditorModel.es6.js |
|---|
| reviewboard/static/rb/js/models/commentIssueManagerModel.es6.js |
|---|
| reviewboard/static/rb/js/models/reviewRequestEditorModel.es6.js |
|---|
| reviewboard/static/rb/js/models/uploadDiffModel.es6.js |
|---|
| reviewboard/static/rb/js/models/userSessionModel.es6.js |
|---|
| reviewboard/static/rb/js/models/tests/commentEditorModelTests.es6.js |
|---|
| reviewboard/static/rb/js/models/tests/reviewRequestEditorModelTests.es6.js |
|---|
| reviewboard/static/rb/js/newReviewRequest/views/newReviewRequestView.es6.js |
|---|
| reviewboard/static/rb/js/newReviewRequest/views/postCommitView.es6.js |
|---|
| reviewboard/static/rb/js/newReviewRequest/views/tests/postCommitViewTests.es6.js |
|---|
| reviewboard/static/rb/js/pages/views/tests/reviewablePageViewTests.es6.js |
|---|
| reviewboard/static/rb/js/resources/models/baseResourceModel.es6.js |
|---|
| reviewboard/static/rb/js/resources/models/draftReviewModel.es6.js |
|---|
| reviewboard/static/rb/js/resources/models/draftReviewRequestModel.es6.js |
|---|
| reviewboard/static/rb/js/resources/models/reviewGroupModel.es6.js |
|---|
| reviewboard/static/rb/js/resources/models/reviewReplyModel.es6.js |
|---|
| reviewboard/static/rb/js/resources/models/reviewRequestModel.es6.js |
|---|
| reviewboard/static/rb/js/resources/models/tests/baseResourceModelTests.es6.js |
|---|
| reviewboard/static/rb/js/resources/models/tests/draftReviewModelTests.es6.js |
|---|