Convert BaseResource.save to return a promise.
Review Request #11642 — Created June 2, 2021 and submitted — Latest diff uploaded
This change updates the save machinery for various resources to use
promises and async/await instead of callbacks.
- Ran js-tests.
- Manually tested API token creation, comment editing, review request
field editing, post-commit review request creation, ship-it revocation,
and file attachment uploading.
Diff Revision 2
This is not the most recent revision of the diff. The latest diff is revision 5. See what's changed.
orig
1
2
3
4
5
Commits
Files
| reviewboard/static/rb/js/resources/models/tests/draftReviewRequestModelTests.es6.js |
|---|
| reviewboard/static/rb/js/resources/models/tests/reviewGroupModelTests.es6.js |
|---|
| reviewboard/static/rb/js/reviewRequestPage/models/reviewReplyEditorModel.es6.js |
|---|
| reviewboard/static/rb/js/reviewRequestPage/models/tests/reviewReplyEditorModelTests.es6.js |
|---|
| reviewboard/static/rb/js/reviewRequestPage/views/reviewEntryView.es6.js |
|---|
| reviewboard/static/rb/js/ui/views/textEditorView.es6.js |
|---|
| reviewboard/static/rb/js/views/commentDialogView.es6.js |
|---|
| reviewboard/static/rb/js/views/reviewDialogView.es6.js |
|---|
| reviewboard/static/rb/js/views/uploadAttachmentView.es6.js |
|---|
| reviewboard/static/rb/js/views/tests/commentDialogViewTests.es6.js |
|---|
| reviewboard/static/rb/js/views/tests/reviewDialogViewTests.es6.js |
|---|
| reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.es6.js |
|---|
| reviewboard/static/rb/js/views/tests/reviewRequestFieldViewsTests.es6.js |
|---|