Summary

Convert field save operations to return promises.

Review Request #11639 — Created June 1, 2021 and submitted Dec. 3, 2021, 3:48 p.m.

Owner

Repository

Review Board

Branch

master

Bugs

Depends On

Groups

People

Description

This change updates the review request field views to use promises for
the save operations instead of callbacks.

Testing Done


Ran js-tests.
Updated various fields on review requests and checked that everything

  worked properly.

Commits

Summary	ID
Convert field save operations to return promises. This change updates the review request field views to use promises for the save operations instead of callbacks. Testing Done: - Ran js-tests. - Updated various fields on review requests and checked that everything worked properly.	ffcb511f72b283324af2fd701fd1e3c5267ee619

flake8 passed.

JSHint passed.

Commits:

	Summary	ID
	Convert field save operations to return promises. This change updates the review request field views to use promises for the save operations instead of callbacks. Testing Done: - Ran js-tests. - Updated various fields on review requests and checked that everything worked properly.	fe75e1a630b29a6f52d9cb2da8698c04463e96b1
	Convert field save operations to return promises. This change updates the review request field views to use promises for the save operations instead of callbacks. Testing Done: - Ran js-tests. - Updated various fields on review requests and checked that everything worked properly.	f5045b54dad93852992b62858253d97a69515b9d

Diff:

Revision 2 (+470 -386)

	reviewboard/static/rb/js/models/reviewRequestEditorModel.es6.js
	reviewboard/static/rb/js/models/tests/reviewRequestEditorModelTests.es6.js
	reviewboard/static/rb/js/views/reviewRequestFieldViews.es6.js
	reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.es6.js
	reviewboard/static/rb/js/views/tests/reviewRequestFieldViewsTests.es6.js

flake8 passed.

JSHint passed.

Change Summary:

Use expectAsync

Commits:

	Summary	ID
	Convert field save operations to return promises. This change updates the review request field views to use promises for the save operations instead of callbacks. Testing Done: - Ran js-tests. - Updated various fields on review requests and checked that everything worked properly.	f5045b54dad93852992b62858253d97a69515b9d
	Convert field save operations to return promises. This change updates the review request field views to use promises for the save operations instead of callbacks. Testing Done: - Ran js-tests. - Updated various fields on review requests and checked that everything worked properly.	ffcb511f72b283324af2fd701fd1e3c5267ee619

Diff:

Revision 3 (+410 -388)

	reviewboard/static/rb/js/models/reviewRequestEditorModel.es6.js
	reviewboard/static/rb/js/models/tests/reviewRequestEditorModelTests.es6.js
	reviewboard/static/rb/js/views/reviewRequestFieldViews.es6.js
	reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.es6.js
	reviewboard/static/rb/js/views/tests/reviewRequestFieldViewsTests.es6.js

flake8 passed.

JSHint passed.

Ship it!