Convert setStarred operations to return promises.

 






 

 


  Review Request #11634
  —
  Created May 28, 2021 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  master
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
This change moves the group and review request star operations to use

promises instead of callbacks.

 








  


 
 

  
    

  • Ran js-tests.
    • 

  • Manually tested starring groups and review requests.
    • 


 







 









 





  








 




 







   

    
    
Changes between revision 1 and 2



    

 

 

 

 
orig
1
2
3

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    

     Convert setStarred operations to return promises.
     
This change moves the group and review request star operations to use
promises instead of callbacks.

Testing Done:
- Ran js-tests.
- Manually tested starring groups and review requests.

    

   
  		
  43463ab1f1c76a8d555d38f755ab91fedc13428c
  David Trowbridge
 


 
  
 
 
  
   
    

     Convert setStarred operations to return promises.
     
This change moves the group and review request star operations to use
promises instead of callbacks.

Testing Done:
- Ran js-tests.
- Manually tested starring groups and review requests.

    

   
  		
  4196bf18e4001ed3146fae9a6add15a68deabe90
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/static/rb/js/views/reviewRequestEditorView.es6.js
     
    

   
  

 










     

    

   

  

  

   
   Loading...