Summary

Convert setStarred operations to return promises.

Review Request #11634 — Created May 28, 2021 and submitted Dec. 3, 2021, 11:48 p.m.

Owner

Repository

Review Board

Branch

master

Bugs

Depends On

Groups

People

Description

This change moves the group and review request star operations to use
promises instead of callbacks.

Testing Done


Ran js-tests.
Manually tested starring groups and review requests.

Commits

Summary	ID
Convert setStarred operations to return promises. This change moves the group and review request star operations to use promises instead of callbacks. Testing Done: - Ran js-tests. - Manually tested starring groups and review requests.	8d189dfb1e3141b2bfe4d8e9239e80454cfce0c8

Issues

Description	From	Last Updated
Col: 59 Missing semicolon.	reviewbot	May 28, 2021, 10:07 p.m.

flake8 passed.

JSHint failed.

Commits:

	Summary	ID
	Convert setStarred operations to return promises. This change moves the group and review request star operations to use promises instead of callbacks. Testing Done: - Ran js-tests. - Manually tested starring groups and review requests.	43463ab1f1c76a8d555d38f755ab91fedc13428c
	Convert setStarred operations to return promises. This change moves the group and review request star operations to use promises instead of callbacks. Testing Done: - Ran js-tests. - Manually tested starring groups and review requests.	4196bf18e4001ed3146fae9a6add15a68deabe90

Diff:

Revision 2 (+156 -208)

	reviewboard/static/rb/js/models/userSessionModel.es6.js
	reviewboard/static/rb/js/pages/models/dashboardModel.es6.js
	reviewboard/static/rb/js/resources/models/reviewGroupModel.es6.js
	reviewboard/static/rb/js/resources/models/reviewRequestModel.es6.js
	reviewboard/static/rb/js/resources/models/tests/reviewGroupModelTests.es6.js
	reviewboard/static/rb/js/resources/models/tests/reviewRequestModelTests.es6.js
	reviewboard/static/rb/js/views/reviewRequestEditorView.es6.js

flake8 passed.

JSHint passed.

Commits:

	Summary	ID
	Convert setStarred operations to return promises. This change moves the group and review request star operations to use promises instead of callbacks. Testing Done: - Ran js-tests. - Manually tested starring groups and review requests.	4196bf18e4001ed3146fae9a6add15a68deabe90
	Convert setStarred operations to return promises. This change moves the group and review request star operations to use promises instead of callbacks. Testing Done: - Ran js-tests. - Manually tested starring groups and review requests.	8d189dfb1e3141b2bfe4d8e9239e80454cfce0c8

Diff:

Revision 3 (+382 -176)

	reviewboard/static/rb/js/models/userSessionModel.es6.js
	reviewboard/static/rb/js/pages/models/dashboardModel.es6.js
	reviewboard/static/rb/js/resources/models/reviewGroupModel.es6.js
	reviewboard/static/rb/js/resources/models/reviewRequestModel.es6.js
	reviewboard/static/rb/js/resources/models/tests/reviewGroupModelTests.es6.js
	reviewboard/static/rb/js/resources/models/tests/reviewRequestModelTests.es6.js
	reviewboard/static/rb/js/views/reviewRequestEditorView.es6.js

flake8 passed.

JSHint passed.

Ship it!