Change ReviewRequest.createFromCommit to return a promise.

Review Request #11632 — Created May 27, 2021 and submitted — Latest diff uploaded

Information

Review Board
master

Reviewers

This change updates the post-commit review request creation method to
return a promise instead of using callbacks for success and error.

  • Ran js-tests.
  • Created a post-commit review request.

Diff Revision 2

This is not the most recent revision of the diff. The latest diff is revision 3. See what's changed.

orig
1
2
3

Commits

First Last Summary ID Author
Change ReviewRequest.createFromCommit to return a promise.
This change updates the post-commit review request creation method to return a promise instead of using callbacks for success and error. Testing Done: - Ran js-tests. - Created a post-commit review request.
efa54a820be84bc5c59484b3186ce53e298cb8a7 David Trowbridge
reviewboard/static/rb/js/newReviewRequest/views/postCommitView.es6.js
reviewboard/static/rb/js/resources/models/reviewRequestModel.es6.js
reviewboard/static/rb/js/resources/models/tests/reviewRequestModelTests.es6.js
Loading...