• 
      

    Cap the pyparsing dependency at 2.4.x.

    Review Request #11595 — Created April 12, 2021 and submitted

    Information

    Review Board
    release-3.0.x

    Reviewers

    pyparsing is needed by a couple different dependencies, including
    setuptools, but versions newer than 2.4.x only support Python 3.

    This change caps us at 2.4.x, in order to avoid any breakages during
    installation.

    We should now have every potentially-unsafe dependency included in a
    default install of Review Board capped to a safe range. That should help
    keep Review Board 3.0.x installable long-term, provided compatible
    versions of Python and pip/easy_install.

    Installed the package in a fresh virtualenv. Verified that it installed
    without issues and that functionality seemed to work without errors.

    Went through site-packages and checked each package, ensuring that any
    that are a direct or indirect dependency of Review Board was capped,
    explicitly a 2.7 backport of a Python 3 feature, or advertises long-term
    support for Python 2.7.

    Summary ID
    Cap the pyparsing dependency at 2.4.x.
    `pyparsing` is needed by a couple different dependencies, including setuptools, but versions newer than 2.4.x only support Python 3. This change caps us at 2.4.x, in order to avoid any breakages during installation. We should now have every potentially-unsafe dependency included in a default install of Review Board capped to a safe range. That should help keep Review Board 3.0.x installable long-term, provided compatible versions of Python and `pip`/`easy_install`.
    b9d705cb67e475e049c058c5d90808caf53509f9
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-3.0.x (46e9ebb)