• 
      

    Update cpplint for new tool support and improve output parsing.

    Review Request #11567 — Created April 1, 2021 and submitted

    Information

    ReviewBot
    release-3.0.x

    Reviewers

    This updates CPPLintTool to subclass the newer BaseTool, and to use
    the newer features it offers (dependencies, improved file extension
    handling, centralized base command building, and standardized error code
    output).

    The new version of the tool has less verbose, safer output parsing. Both
    the old and new versions used a regex, but the new one is designed to
    better fit with the output from the tool, and to avoid a bunch of
    now-unnecesary processing.

    Unit tests pass for Python 2.7 and 3.x.

    Summary ID
    Update cpplint for new tool support and improve output parsing.
    This updates `CPPLintTool` to subclass the newer `BaseTool`, and to use the newer features it offers (dependencies, improved file extension handling, centralized base command building, and standardized error code output). The new version of the tool has less verbose, safer output parsing. Both the old and new versions used a regex, but the new one is designed to better fit with the output from the tool, and to avoid a bunch of now-unnecesary processing.
    3c35336790d475a6707ef819ca6dc322a7473600
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-3.0.x (37b0135)