Update pyflakes for new tool support and fixes to parsing.
Review Request #11556 — Created March 26, 2021 and submitted — Latest diff uploaded
This updates
PyflakesToolto subclass the newerBaseTool, and to use
the newer features it offers (dependencies, centralized base command
building, and standardized error code/column output).It also fixes some mistakes from my prior pyflakes change. It turns out
pyflakes has some inconsistencies with a colon found in the generated
output, and this led to issues with parsing some of the output.On top of this,
execute()'sreturn_errorscombined with
split_linesdidn't do the right thing when usingwith_errors=True
(the default). That's been corrected to givereturn_errorsprecedence.These were caught by the new integration tests, which are also added in
this change.
All unit tests pass on Python 2.x and 3.x.