Update the PMD code, docs, configuration, and tests for the latest changes.
Review Request #11530 — Created March 16, 2021 and submitted
PMD has been updated to use the renamed
BaseTool
class and to take
advantage of the new dependency management, to simplify code.As part of this, configuration has become standardized, allowing the
pmd
tool path to be located on the fileystem (if in$PATH
) or
configured in the worker'sexe_paths
setting. This has the additional
small benefit of caching thepmd
binary path, so it doesn't have to be
looked up in$PATH
at execution time.The old
pmd_path
setting has been deprecated. It will be transitioned
over when loading the configuration. Documentation has been updated to
discuss this.The list of file extensions are now more forgiving. Extra commas, spaces,
and leading.
for file extensions are handled correctly.The documentation has been fleshed out to go over the fields present
during tool configuration.Unit tests have been added for
handle_file()
, to give us a base for
future work and to ensure that the cachedpmd
path is being used.
Unit tests pass.
Tested dependency checking in the worker, with
pmd
in the$PATH
and with an explicit path provided inexe_paths
.Built the docs. Checked for build errors, spelling errors, and bad links.
Summary | ID |
---|---|
eeb5b24cf4fadf0961a3b4b5b513f0f82d3c7cc7 |
Description | From | Last Updated |
---|---|---|
F401 'reviewbot.config.config' imported but unused |
reviewbot | |
F811 redefinition of unused 'config' from line 9 |
reviewbot | |
F811 redefinition of unused 'config' from line 9 |
reviewbot | |
F841 local variable 'review' is assigned to but never used |
reviewbot | |
F841 local variable 'review' is assigned to but never used |
reviewbot | |
F811 redefinition of unused 'config' from line 9 |
reviewbot |
- Change Summary:
-
Removed unused imports and variables in
test_pmd.py
. - Commits:
-
Summary ID 25503f21661aa2ff863044d220892c6dd3b5272a 4dc0827bf96d95d3521d5ce73b48b858cfae88ad
Checks run (2 succeeded)
- Change Summary:
-
Updated the file extension handling support to set the new
file_patterns
. - Description:
-
PMD has been updated to use the renamed
BaseTool
class and to takeadvantage of the new dependency management, to simplify code. As part of this, configuration has become standardized, allowing the
pmd
tool path to be located on the fileystem (if in$PATH
) orconfigured in the worker's exe_paths
setting. This has the additionalsmall benefit of caching the pmd
binary path, so it doesn't have to belooked up in $PATH
at execution time.The old
pmd_path
setting has been deprecated. It will be transitionedover when loading the configuration. Documentation has been updated to discuss this. + The list of file extensions are now more forgiving. Extra commas, spaces,
+ and leading .
for file extensions are handled correctly.+ The documentation has been fleshed out to go over the fields present
during tool configuration. Unit tests have been added for
handle_file()
, to give us a base forfuture work and to ensure that the cached pmd
path is being used. - Commits:
-
Summary ID 4dc0827bf96d95d3521d5ce73b48b858cfae88ad 995e0bebb540edd92329bcb69ff466738cf0150d