Add a "Last Updated By" column to ReviewBoard dashboard

 






 

 


  Review Request #11524
  —
  Created March 14, 2021 and updated  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  clarissaudrey
 









 
 

  Review Board
 









 
 

  master
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard, students
 









 
 

  
 






 








 





  


 
 

  
Currently, the last updated column only shows the timestamp

of last activity that has occurred. It is desireable to show

the user who is responsible for the last activity as well.

Therefore, we need to add another column "Last Updated By" to

the dashboard.

 








  


 
 

  
Manual testing:

1. On the UI, activate the new Last Updated By column by selecting it.

2. It should show the user (linkable to the user's profile) that is

   responsible for the last update.

Tested on Safari, Chrome, and Firefox.


Automated unit testing:

1. Run ./tests/runtests.py reviewboard.datagrids.tests.

 







 









 





  








 




 







   

    
    
Diff Revision 7 (Latest)



    

 

 

 

 
orig
1
2
3
4
5
6
7

 



    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    
Add class LastUpdatedByColumn and override get_user method

   
  		
  255db9e04b1a4928e07e6a3ead76f8c82335f85b
  Clarissa Audrey
 


 
  
   
  
  
   
  
 
 
  
   
    
Fixed import module

   
  		
  b205836025ceaa6c0edbb9b2ed8cab2c7543968f
  Clarissa Audrey
 


 
  
   
  
  
   
  
 
 
  
   
    
Implemented get_user based on the last activity and added the column to the g...

   
  		
  68529a8640bbaa2834f8a1a14d8d71104a6ca934
  Clarissa Audrey
 


 
  
   
  
  
   
  
 
 
  
   
    
Fixed formatting

   
  		
  8d6e529f89548a65a743e88b31ef35457204bf81
  Clarissa Audrey
 


 
  
   
  
  
   
  
 
 
  
   
    
Fixed rendering column for last_updated_by

   
  		
  d8b52f1fbfa369a6d746aac5602f1f5b86d67175
  Clarissa Audrey
 


 
  
   
  
  
   
  
 
 
  
   
    
Fixed get_user

   
  		
  c9db8baabca7b96a0104deba3f039798225d2335
  Clarissa Audrey
 


 
  
   
  
  
   
  
 
 
  
   
    
Added unit tests for Last Updated By column

   
  		
  0266cd3020c961dda57562506c34a0eb21017086
  Clarissa Audrey
 


 
  
   
  
  
   
  
 
 
  
   
    
Fixed line too long error

   
  		
  1b6a908d77f50b5187a88cbf4ed9bfd95d73315e
  Clarissa Audrey
 


 
  
   
  
  
   
  
 
 
  
   
    
Removed unused fields in datagrids/tests.py

   
  		
  4e8b1bee638b480283a3e914d9db44a967809691
  Clarissa Audrey
 


 
  
   
  
  
   
  
 
 
  
   
    
Fixes based on mentor's reviews

   
  		
  bf1ba709d8cf9b4592948efccdac617ae7bc2958
  Clarissa Audrey
 


 
  
   
  
  
   
  
 
 
  
   
    
Fixed trailing whitespace

   
  		
  445fe015a763bd92edce046b460b2c6ed7623b31
  Clarissa Audrey
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/datagrids/columns.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/datagrids/grids.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/datagrids/tests.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...