Fix for AD account backend group enumeration issue

 






 

 


  Review Request #1152
  —
  Created Oct. 5, 2009 and submitted — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  smat
 









 
 

  Review Board
 









 
 

  
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
This patch updates the search query to use CN rather than sAMAccountName so that groups which have CNs that differ from their sAMAccountNames (e.g. if a "pre-Windows 2000" group name is set in Active Directory) will be included in the search results. The memberOf property used here to find groups specifies groups by DN, so searching on the CN component should always be the correct behavior (as far possible, using the full DN would be safer).

 








  


 
 

  
Tested on local installation of Review Board 1.0.3