Summary

Move SCM-provided repository name out of RepositoryInfo structure.

Review Request #11504 — Created March 8, 2021 and submitted March 23, 2021, 10:49 p.m.

Information

Owner

david

Repository

RBTools

Branch

master

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

This change moves the repository name out of the RepositoryInfo
structure and into a method which is only called if the repository name
is not provided in another way. It also actually uses that name when
querying the repositories inside the get_repository_id method (as
opposed to fetching all repositories and then comparing against the
name).

Testing Done


Ran unit tests.
Verified that get_repository_id was now only fetching a single

  repository from the API during commands such as rbt status and

rbt post -u.

Commits

Summary	ID
Move SCM-provided repository name out of RepositoryInfo structure. Perforce allows administrators to configure the repository name into the p4 counters. This was then used in the case where the name was not already provided from the config or command line options. Unfortunately, this was stuck into the RepositoryInfo structure, which wasn't the best place for it. This also meant that even when the repository name was configured in .reviewboardrc, we'd query the p4 counters looking for it. This change moves the repository name out of the RepositoryInfo structure and into a method which is only called if the repository name is not provided in another way. It also actually uses that name when querying the repositories inside the `get_repository_id` method (as opposed to fetching all repositories and then comparing against the name). Testing Done: - Ran unit tests. - Verified that `get_repository_id` was now only fetching a single repository from the API during commands such as `rbt status` and `rbt post -u`.	2e875f79db0ab4faf073fba973c3cc78c2b66189

Summary

Move SCM-provided repository name out of RepositoryInfo structure.

Perforce allows administrators to configure the repository name into the p4 counters. This was then used in the case where the name was not already provided from the config or command line options. Unfortunately, this was stuck into the RepositoryInfo structure, which wasn't the best place for it. This also meant that even when the repository name was configured in .reviewboardrc, we'd query the p4 counters looking for it. This change moves the repository name out of the RepositoryInfo structure and into a method which is only called if the repository name is not provided in another way. It also actually uses that name when querying the repositories inside the `get_repository_id` method (as opposed to fetching all repositories and then comparing against the name). Testing Done: - Ran unit tests. - Verified that `get_repository_id` was now only fetching a single repository from the API during commands such as `rbt status` and `rbt post -u`.

2e875f79db0ab4faf073fba973c3cc78c2b66189

Issues

Description	From	Last Updated
E501 line too long (81 > 79 characters)	reviewbot	March 8, 2021, 1:17 p.m.
Let's use :py:meth: to reference get_repository_name.	chipx86	March 11, 2021, 2:04 p.m.
Can this be one statement?	chipx86	March 11, 2021, 2:05 p.m.
Can you add Version Added here, before Returns?	chipx86	March 23, 2021, 10:48 p.m.
This needs to go right after the description text, before Args.	chipx86	March 23, 2021, 10:48 p.m.

flake8 failed.

JSHint passed.

flake8

rbtools/clients/__init__.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (81 > 79 characters)
```

Commits:

	Summary	ID
	Move SCM-provided repository name out of RepositoryInfo structure. Perforce allows administrators to configure the repository name into the p4 counters. This was then used in the case where the name was not already provided from the config or command line options. Unfortunately, this was stuck into the RepositoryInfo structure, which wasn't the best place for it. This also meant that even when the repository name was configured in .reviewboardrc, we'd query the p4 counters looking for it. This change moves the repository name out of the RepositoryInfo structure and into a method which is only called if the repository name is not provided in another way. It also actually uses that name when querying the repositories inside the `get_repository_id` method (as opposed to fetching all repositories and then comparing against the name). Testing Done: - Ran unit tests. - Verified that `get_repository_id` was now only fetching a single repository from the API during commands such as `rbt status` and `rbt post -u`.	05939566a81bf59ca12dbc3dcf37bc835b5ff08d
	Move SCM-provided repository name out of RepositoryInfo structure. Perforce allows administrators to configure the repository name into the p4 counters. This was then used in the case where the name was not already provided from the config or command line options. Unfortunately, this was stuck into the RepositoryInfo structure, which wasn't the best place for it. This also meant that even when the repository name was configured in .reviewboardrc, we'd query the p4 counters looking for it. This change moves the repository name out of the RepositoryInfo structure and into a method which is only called if the repository name is not provided in another way. It also actually uses that name when querying the repositories inside the `get_repository_id` method (as opposed to fetching all repositories and then comparing against the name). Testing Done: - Ran unit tests. - Verified that `get_repository_id` was now only fetching a single repository from the API during commands such as `rbt status` and `rbt post -u`.	329aaf827433af5e054c3ea0dfba5457f623d35d

Diff:

Revision 2 (+150 -54)

Show changes

	rbtools/clients/__init__.py
	rbtools/clients/perforce.py
	rbtools/clients/tests/test_p4.py
	rbtools/commands/__init__.py
	rbtools/utils/repository.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

rbtools/clients/__init__.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Let's use :py:meth: to reference get_repository_name.
```
rbtools/utils/repository.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Can this be one statement?
```

Commits:

	Summary	ID
	Move SCM-provided repository name out of RepositoryInfo structure. Perforce allows administrators to configure the repository name into the p4 counters. This was then used in the case where the name was not already provided from the config or command line options. Unfortunately, this was stuck into the RepositoryInfo structure, which wasn't the best place for it. This also meant that even when the repository name was configured in .reviewboardrc, we'd query the p4 counters looking for it. This change moves the repository name out of the RepositoryInfo structure and into a method which is only called if the repository name is not provided in another way. It also actually uses that name when querying the repositories inside the `get_repository_id` method (as opposed to fetching all repositories and then comparing against the name). Testing Done: - Ran unit tests. - Verified that `get_repository_id` was now only fetching a single repository from the API during commands such as `rbt status` and `rbt post -u`.	329aaf827433af5e054c3ea0dfba5457f623d35d
	Move SCM-provided repository name out of RepositoryInfo structure. Perforce allows administrators to configure the repository name into the p4 counters. This was then used in the case where the name was not already provided from the config or command line options. Unfortunately, this was stuck into the RepositoryInfo structure, which wasn't the best place for it. This also meant that even when the repository name was configured in .reviewboardrc, we'd query the p4 counters looking for it. This change moves the repository name out of the RepositoryInfo structure and into a method which is only called if the repository name is not provided in another way. It also actually uses that name when querying the repositories inside the `get_repository_id` method (as opposed to fetching all repositories and then comparing against the name). Testing Done: - Ran unit tests. - Verified that `get_repository_id` was now only fetching a single repository from the API during commands such as `rbt status` and `rbt post -u`.	2e875f79db0ab4faf073fba973c3cc78c2b66189

Diff:

Revision 3 (+154 -60)

Show changes

	rbtools/clients/__init__.py
	rbtools/clients/perforce.py
	rbtools/clients/tests/test_p4.py
	rbtools/commands/__init__.py
	rbtools/utils/repository.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

rbtools/clients/__init__.py (Diff revision 3)

The issue has been resolved. Show all issues

Can you add Version Added here, before Returns?

rbtools/clients/__init__.py (Diff revision 3)

The issue has been resolved. Show all issues

This needs to go right after the description text, before Args.

Status:: Completed
Change Summary:: Pushed to master (a98f021)