• 
  
    
 
    
 
    

    



    
    
    
    
     
    






    
 
    


 
    



    
 

 

  

  

 

    


  
    





    
 
    



  

    
 
 
    
  
    Fix packaging extensions on Python 3.
    
 
    

    



 
    
 
    

  Review Request #11486
  —
  Created Feb. 25, 2021 and submitted  — Latest diff uploaded 

 
    


    




    




    




 
    
  
    
   Information

  
    



    
 
 
    
  chipx86
 
    

    





    
 
 
    
  Djblets
 
    

    





    
 
 
    
  release-2.x
 
    

    





    
 
 
    
  
 
    

    





    
 
 
    
  
 
    

    



 
    



 
    
  
    
   Reviewers

  
    



    
 
 
    
  djblets
 
    

    





    
 
 
    
  
 
    

    



 
    



    


    
 
    




  

    
 
 
    
  
    We had a couple of hard-coded byte strings for setup.py command
    
options, which broke on Python 3. We wanted to use native strings to
    
ensure Unicode on Python 3 and bytes on Python 2.
    

    This change simply wraps each in a str() to ensure native string
    
types.
    
 
    

    





  

    
 
 
    
  
    Ran ./setup.py bdist_wheel on an extension and saw it work without
    
crashes. Previously, it complained about the byte string.
    
 
    

    




 
    

    





    
 
    









 




 
    

    




   
    
    
    
    
    
    
    
    

    
    
      
    Commits
    
      
    
        
      
    
    
    

    
    

      
    Files