Summary

Fix packaging extensions on Python 3.

Review Request #11486 — Created Feb. 25, 2021 and submitted Feb. 27, 2021, 1:31 p.m.

Information

Owner

chipx86

Repository

Djblets

Branch

release-2.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

We had a couple of hard-coded byte strings for setup.py command
options, which broke on Python 3. We wanted to use native strings to
ensure Unicode on Python 3 and bytes on Python 2.

This change simply wraps each in a str() to ensure native string
types.

Testing Done

Ran ./setup.py bdist_wheel on an extension and saw it work without
crashes. Previously, it complained about the byte string.

Commits

Summary	ID
Fix packaging extensions on Python 3. We had a couple of hard-coded byte strings for `setup.py` command options, which broke on Python 3. We wanted to use native strings to ensure Unicode on Python 3 and bytes on Python 2. This change simply wraps each in a `str()` to ensure native string types.	e2b63da307f7f2d612b3e41193b5a823c8e91479

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.x (a75a73b)