[WIP] Support exploring archive files attached to reviews.

 






 

 


  Review Request #11402
  —
  Created Jan. 24, 2021 and updated  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  mfliu
 









 
 

  Review Board
 









 
 

  master
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard, students
 









 
 

  
 






 








 





  


 
 

  
ReviewBoard currently supports attaching individual files for review,
but while some filetypes can be opened in-browser and examined, archive
files can only be downloaded. This commit adds a new review UI that
allows archives to be browsed in ReviewBoard without downloading the
file. Users can navigate the archived files, see metadata, and download
individual files.

 








  


 
 

  
Unit tests for get_js_model_data using empty archives, simple archives with files, and archives with nested directories.

 







 









 





  








 




 







   

    
    
Changes between revision 7 and 8



    

 

 

 

 
orig
1
2
3
4
5
6
7
8
9
10
11
12

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    

     [WIP] Support exploring archive files attached to reviews.
     
ReviewBoard currently supports attaching individual files for review,
but while some filetypes can be opened in-browser and examined, archive
files can only be downloaded. This commit adds a new review UI that
allows archives to be browsed in ReviewBoard without downloading the
file. Users can navigate the archived files, see metadata, and download
individual files.

    

   
  		
  bbcc492a3ee3495c52cf11076a9847c1e7bfa5b2
  Michael Liu
 


 
  
 
 
  
   
    

     [WIP] Support exploring archive files attached to reviews.
     
ReviewBoard currently supports attaching individual files for review,
but while some filetypes can be opened in-browser and examined, archive
files can only be downloaded. This commit adds a new review UI that
allows archives to be browsed in ReviewBoard without downloading the
file. Users can navigate the archived files, see metadata, and download
individual files.

    

   
  		
  ed9822e43ec0a2a0fe4a6112a677b3b397bc2700
  Michael Liu
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/reviews/ui/archive.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/views/archiveReviewableView.es6.js
     
    

   
  

 










     

    

   

  

  

   
   Loading...