Added logger global variable to have named logging in files in reviewboard.attachments
Review Request #11394 — Created Jan. 22, 2021 and discarded — Latest diff uploaded
Previously logging in
reviewboard/reviewboard/attachments
was
un-named logging. This means it's hard to determine where the
error came from in the logs.To fix this a global
logger
variable was defined in each file
that adds the location of the file to the error message.
Added unit test for
unregister_mimetype_handler
that passes it an
unregistered handler. This should cause an error to be logged. The
unit test listens to whether or not the logger ran.Ran
./tests/runtests.py reviewboard.attachments
and passed all 32 tests.
Diff Revision 4 (Latest)
orig
1
2
3
4
Commits
Files
reviewboard/reviews/tests/test_new_review_request_view.py |
---|
reviewboard/reviews/tests/test_reviewtags.py |
---|
reviewboard/reviews/ui/base.py |
---|
reviewboard/reviews/ui/markdownui.py |
---|
reviewboard/reviews/ui/text.py |
---|
reviewboard/search/search_backends/base.py |
---|
reviewboard/search/tests/test_search_backend.py |
---|
reviewboard/ssh/client.py |
---|
reviewboard/ssh/errors.py |
---|
reviewboard/ssh/storage.py |
---|
reviewboard/static/rb/css/ui/sidebars.less |
---|
reviewboard/static/rb/js/newReviewRequest/views/commitView.es6.js |
---|
reviewboard/static/rb/js/ui/views/dialogView.es6.js |
---|
reviewboard/static/rb/js/ui/views/tests/dialogViewTests.es6.js |
---|
reviewboard/templates/admin/sidebar.html |
---|
reviewboard/webapi/base.py |
---|
reviewboard/webapi/decorators.py |
---|
reviewboard/webapi/server_info.py |
---|
reviewboard/webapi/resources/base_original_file.py |
---|
reviewboard/webapi/resources/base_patched_file.py |
---|
reviewboard/webapi/resources/base_review_request_file_attachment.py |
---|
reviewboard/webapi/resources/diff.py |
---|
reviewboard/webapi/resources/review_request.py |
---|
reviewboard/webapi/resources/validate_diff.py |
---|