Added logger global variable to have named logging in files in reviewboard.attachments
Review Request #11394 — Created Jan. 22, 2021 and discarded — Latest diff uploaded
Previously logging in
reviewboard/reviewboard/attachments
was
un-named logging. This means it's hard to determine where the
error came from in the logs.To fix this a global
logger
variable was defined in each file
that adds the location of the file to the error message.
Added unit test for
unregister_mimetype_handler
that passes it an
unregistered handler. This should cause an error to be logged. The
unit test listens to whether or not the logger ran.Ran
./tests/runtests.py reviewboard.attachments
and passed all 32 tests.
Diff Revision 4 (Latest)
orig
1
2
3
4
Commits
Files
AUTHORS |
---|
contrib/docker/Dockerfile |
---|
contrib/docker/build.py |
---|
contrib/docker/examples/docker-compose.mysql.yaml |
---|
contrib/docker/examples/docker-compose.postgres.yaml |
---|
contrib/docker/examples/nginx_templates/reviewboard.conf.template |
---|
contrib/docker/examples/postgres/init-reviewboard-db.sh |
---|
contrib/docker/packages/.gitignore |
---|
contrib/docker/scripts/docker-entrypoint.sh |
---|
contrib/docker/scripts/serve.sh |
---|
contrib/internal/prepare-dev.py |
---|
docs/manual/Makefile |
---|
docs/manual/conf.py |
---|
docs/manual/docsmanage.py |
---|
docs/manual/admin/index.rst |
---|
docs/manual/admin/installation/development-releases.rst |
---|
docs/manual/admin/installation/docker.rst |
---|
docs/manual/admin/installation/index.rst |
---|
docs/manual/admin/installation/linux.rst |
---|
docs/manual/admin/sites/rb-site.rst |
---|