Added logger global variable to have named logging in files in reviewboard.attachments
Review Request #11394 — Created Jan. 22, 2021 and discarded — Latest diff uploaded
Previously logging in
reviewboard/reviewboard/attachments
was
un-named logging. This means it's hard to determine where the
error came from in the logs.To fix this a global
logger
variable was defined in each file
that adds the location of the file to the error message.
Added unit test for
unregister_mimetype_handler
that passes it an
unregistered handler. This should cause an error to be logged. The
unit test listens to whether or not the logger ran.Ran
./tests/runtests.py reviewboard.attachments
and passed all 32 tests.
Changes between revision 3 and 4
orig
1
2
3
4
Commits
Files
reviewboard/cmdline/rbext.py |
---|
reviewboard/cmdline/rbsite.py |
---|
reviewboard/cmdline/conf/reviewboard.wsgi.in |
---|
reviewboard/cmdline/tests/test_rbsite.py |
---|
reviewboard/cmdline/utils/__init__.py |
---|
reviewboard/cmdline/utils/argparsing.py |
---|
reviewboard/cmdline/utils/console.py |
---|
reviewboard/extensions/hooks.py |
---|
reviewboard/extensions/templatetags/rb_extensions.py |
---|
reviewboard/reviews/detail.py |
---|
reviewboard/reviews/fields.py |
---|
reviewboard/reviews/managers.py |
---|
reviewboard/reviews/views.py |
---|
reviewboard/reviews/models/file_attachment_comment.py |
---|
reviewboard/reviews/models/group.py |
---|
reviewboard/reviews/models/review.py |
---|
reviewboard/reviews/models/review_request.py |
---|
reviewboard/reviews/templatetags/reviewtags.py |
---|
reviewboard/reviews/tests/test_entries.py |
---|
reviewboard/reviews/tests/test_new_review_request_view.py |
---|