Summary

Allow to use --print with full review request URL

Review Request #11381 — Created Jan. 14, 2021 and discarded March 24, 2021, 8:52 a.m.

Information

Owner

misery

Repository

RBTools

Branch

release-2.0.x

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

rbt 2.0 introduced the possibility to provide the
review request number as full URL. But this wasn't
possible for --print option.

  rbt patch --print https://reviewboard/r/12345
  ERROR: Unable to find a Review Board server for this source code tree.

This change allows the usage, too.

Testing Done

Tried rbt patch --print https://reviewboard/r/12345 after fix
and saw that is printed the diff to stdout.

Tried rbt patch --print 12345 without repository and saw
that the error from above.

Commits

Summary	ID
Allow to use --print with full review request URL rbt 2.0 introduced the possibility to provide the review request number as full URL. But this wasn't possible for --print option. rbt patch --print https://reviewboard/r/12345 ERROR: Unable to find a Review Board server for this source code tree. This change allows the usage, too.	ab39f170a821dd2005471827a3d3b37496dd4202

flake8 passed.

JSHint passed.

I just landed a change which fixed this in a different way, so I'm going to discard this particular change. Thanks for bringing it to our attention!

Status:: Discarded