Summary

Remove rb-site's global site variable.

Review Request #11365 — Created Jan. 12, 2021 and submitted Jan. 12, 2021, 11:41 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This removes the global site variable from rb-site, which defines the
site that a command will operate on. Instead of managing this as a
global, it's now passed to Command.run(), which can store and operate
on that.

This improves testability and cleans up the code.

Testing Done

Tested all commands thoroughly.

Commits

Summary	ID
Remove rb-site's global site variable. This remoes the global `site` variable from rb-site, which defines the site that a command will operate on. Instead of managing this as a global, it's now passed to `Command.run()`, which can store and operate on that. This improves testability and cleans up the code.	7c619faaf01aee3e9b0ca4acd3427fea7b2c283b

Issues

Description	From	Last Updated
Typo in description: remoes -> removes	david	Jan. 12, 2021, 11:40 p.m.

flake8 passed.

JSHint passed.

Ship it!

The issue has been resolved. Show all issues
```
Typo in description: remoes -> removes
```

Description:: ~
This remoes the global site variable from rb-site, which defines the
~
This removes the global site variable from rb-site, which defines the
site that a command will operate on. Instead of managing this as a
global, it's now passed to Command.run(), which can store and operate
on that.

This improves testability and cleans up the code.

Status:: Completed
Change Summary:: Pushed to release-4.0.x (5bf985f)

~		This remoes the global `site` variable from rb-site, which defines the
	~	This removes the global `site` variable from rb-site, which defines the
		site that a command will operate on. Instead of managing this as a
		global, it's now passed to `Command.run()`, which can store and operate
		on that.

		This improves testability and cleans up the code.