• 
      

    Remove rb-site's global options variable.

    Review Request #11364 — Created Jan. 8, 2021 and submitted

    Information

    Review Board
    release-4.0.x

    Reviewers

    This removes the global options variable from rb-site, making it
    easier to test commands, and preparing for some work toward redoing the
    argument parsing.

    parse_options() now returns the calculated options, and
    Command.run() takes it as an argument. These were the only places that
    made use of the global variable previously.

    Ran all commands successfully.

    Summary ID
    Remove rb-site's global options variable.
    This removes the global `options` variable from rb-site, making it easier to test commands, and preparing for some work toward redoing the argument parsing. `parse_options()` now returns the calculated `options`, and `Command.run()` takes it as an argument. These were the only places that made use of the global variable previously.
    ae94500c465d685f490ff1c5789f6040c2427f75
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-4.0.x (e184da1)