• 
      

    Move rb-site SiteList managmeent into the command classes.

    Review Request #11363 — Created Jan. 8, 2021 and submitted

    Information

    Review Board
    release-4.0.x

    Reviewers

    As part of a cleanup effort leading toward modern argument parsing
    support, this change moves some of the SiteList parsing/management
    code out of main() and into each individual command class. That avoids
    the mixed logic we had before, simplifying main(), and enables
    testability.

    Unit tests were added, as part of an effort to begin building a test
    suite for rb-site.

    Unit tests pass.

    Tested each command with valid and invalid site pathhs.

    Tested the upgrade command with --all-sites.

    Summary ID
    Move rb-site SiteList managmeent into the command classes.
    As part of a cleanup effort leading toward modern argument parsing support, this change moves some of the `SiteList` parsing/management code out of `main()` and into each individual command class. That avoids the mixed logic we had before, simplifying `main()`, and enables testability. Unit tests were added, as part of an effort to begin building a test suite for `rb-site`.
    3bb7185051522dde086a17370b894a80ba62cb16
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-4.0.x (dfccb84)