This change has been marked as completed.

Describe the completed change (optional):

Pushed to release-4.0.x (d41b0e7)

Summary

Split the reviewboard.search unit tests into multiple files.

Review Request #11346 — Created Dec. 23, 2020 and submitted 4 years, 5 months ago

Information

Owner

chipx86*

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description*

reviewboard.search.tests was getting a bit hard to manage, and new
tests for new classes will soon be written. To prepare for this, this
change splits the test suite into 3 new files.

The test code is largely unchanged, with a few exceptions:

Missing/broken docstrings were added/corrected.
Some Django 1.6-specific code has been removed.
A KGB call has been updated for modern best practices.

Testing Done

Unit tests pass on Python 2.7 and 3.6 through 3.9.

Ensured I didn't have a stale tests.pyc or __pycache__ around.

Commits

Summary	ID
Split the reviewboard.search unit tests into multiple files. `reviewboard.search.tests` was getting a bit hard to manage, and new tests for new classes will soon be written. To prepare for this, this change splits the test suite into 3 new files. The test code is largely unchanged, with a few exceptions: 1. Missing/broken docstrings were added/corrected. 2. Some Django 1.6-specific code has been removed. 3. A KGB call has been updated for modern best practices.	29f37b44a9ea674acb4d3f441b02295973c205c4

Summary

Split the reviewboard.search unit tests into multiple files.

`reviewboard.search.tests` was getting a bit hard to manage, and new tests for new classes will soon be written. To prepare for this, this change splits the test suite into 3 new files. The test code is largely unchanged, with a few exceptions: 1. Missing/broken docstrings were added/corrected. 2. Some Django 1.6-specific code has been removed. 3. A KGB call has been updated for modern best practices.

29f37b44a9ea674acb4d3f441b02295973c205c4

Issues

Description	From	Last Updated
W391 blank line at end of file	reviewbot	4 years, 5 months ago
There are no open issues

flake8 failed.

JSHint passed.

flake8

reviewboard/search/tests/test_search_view.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W391 blank line at end of file
```

Ship it!

Once Review Bot is happy, this looks good.

Status:: Completed
Change Summary:: Pushed to release-4.0.x (d41b0e7)