Summary

Fix anchors when publishing a reply to a header or footer.

Review Request #11324 — Created Dec. 7, 2020 and submitted Dec. 8, 2020, 5:03 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This change fixes all this up properly by building an anchor that
involves the replyObject's ID. This will be attached to the anchor
prefix, creating one complete anchor.

This works for comments, headers, and footers.

Testing Done

Tested replies for each reply type, verifying the results.

Unit tests pass.

Commits

Summary	ID
Fix anchors when publishing a reply to a header or footer. The recent change to fix the anchors for a reply when publishing didn't work quite right. Comments were fine, but it didn't work for headers or footers. At some point during my development on it, those did, but they regressed as I reworked some of the code. This change fixes all this up properly by building an anchor that involves the `replyObject`'s ID. This will be attached to the anchor prefix, creating one complete anchor. This works for comments, headers, and footers.	0635e7c9f7efa4156757fe8ea647a1baaa88b61e

Summary

Fix anchors when publishing a reply to a header or footer.

The recent change to fix the anchors for a reply when publishing didn't work quite right. Comments were fine, but it didn't work for headers or footers. At some point during my development on it, those did, but they regressed as I reworked some of the code. This change fixes all this up properly by building an anchor that involves the `replyObject`'s ID. This will be attached to the anchor prefix, creating one complete anchor. This works for comments, headers, and footers.

0635e7c9f7efa4156757fe8ea647a1baaa88b61e

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-3.0.x (1e5cd9d)