Summary

Make cleartool location configurable.

Review Request #11290 — Created Nov. 19, 2020 and submitted Nov. 27, 2020, 2:22 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

In some cases, the cleartool executable may be in an unusual location,
have an alternate name, or users may want to use a wrapper script of
some sort. This change adds an optional settings key to allow people to
set the location or name of cleartool.

Testing Done

Ran unit tests.

Commits

Summary	ID
Make cleartool location configurable. In some cases, the cleartool executable may be in an unusual location, have an alternate name, or users may want to use a wrapper script of some sort. This change adds an optional settings key to allow people to set the location or name of cleartool. Testing Done: Ran unit tests.	6867bead8f9e169dea8eb94b61fedb9c3d9ee529

Issues

Description	From	Last Updated
E501 line too long (83 > 79 characters)	reviewbot	Nov. 19, 2020, 10:53 a.m.
E303 too many blank lines (2)	reviewbot	Nov. 19, 2020, 10:52 a.m.
F811 redefinition of unused 'test_get_cleartool_custom' from line 27	reviewbot	Nov. 19, 2020, 10:53 a.m.
E303 too many blank lines (2)	reviewbot	Nov. 19, 2020, 10:59 a.m.
Can we define a new named logger in this file? That'll provide some context.	chipx86	Nov. 20, 2020, 9:11 a.m.
I'm not 100% sure that this will do the right thing if it's an absolute path. I think we just …	chipx86	Nov. 20, 2020, 9:13 a.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/scmtools/clearcase.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (83 > 79 characters)
```
reviewboard/scmtools/tests/test_clearcase.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E303 too many blank lines (2)
```
reviewboard/scmtools/tests/test_clearcase.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F811 redefinition of unused 'test_get_cleartool_custom' from line 27
```

Commits:

	Summary	ID
	Make cleartool location configurable. In some cases, the cleartool executable may be in an unusual location, have an alternate name, or users may want to use a wrapper script of some sort. This change adds an optional settings key to allow people to set the location or name of cleartool. Testing Done: Ran unit tests.	e0b11a8e7645dad7e8815a8f00689da99eccd317
	Make cleartool location configurable. In some cases, the cleartool executable may be in an unusual location, have an alternate name, or users may want to use a wrapper script of some sort. This change adds an optional settings key to allow people to set the location or name of cleartool. Testing Done: Ran unit tests.	ff3881dea1d676871b3bb0ad54bf1c373acee6c0

Diff:

Revision 2 (+152 -14)

Show changes

	contrib/conf/settings_local.py.tmpl
	reviewboard/scmtools/clearcase.py
	reviewboard/scmtools/tests/test_clearcase.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/scmtools/tests/test_clearcase.py (Diff revision 2)
The issue has been resolved. Show all issues
```
E303 too many blank lines (2)
```

Change Summary:

Actually commit all files.

Commits:

	Summary	ID
	Make cleartool location configurable. In some cases, the cleartool executable may be in an unusual location, have an alternate name, or users may want to use a wrapper script of some sort. This change adds an optional settings key to allow people to set the location or name of cleartool. Testing Done: Ran unit tests.	ff3881dea1d676871b3bb0ad54bf1c373acee6c0
	Make cleartool location configurable. In some cases, the cleartool executable may be in an unusual location, have an alternate name, or users may want to use a wrapper script of some sort. This change adds an optional settings key to allow people to set the location or name of cleartool. Testing Done: Ran unit tests.	6867bead8f9e169dea8eb94b61fedb9c3d9ee529

Diff:

Revision 3 (+150 -14)

Show changes

	contrib/conf/settings_local.py.tmpl
	reviewboard/scmtools/clearcase.py
	reviewboard/scmtools/tests/test_clearcase.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/scmtools/clearcase.py (Diff revision 3)

The issue has been resolved. Show all issues

Can we define a new named logger in this file? That'll provide some context.

david Nov. 20, 2020, 9:13 a.m.
```
I'm going to do that in a later change.
```

reviewboard/scmtools/clearcase.py (Diff revision 3)

The issue has been dropped. Show all issues

I'm not 100% sure that this will do the right thing if it's an absolute path. I think we just look for the binary in the path. Can you check?

david Nov. 20, 2020, 9:13 a.m.

is_exe_in_path works correctly when passed in an absolute path.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (dda2c32)