Make cleartool location configurable.

Review Request #11290 — Created Nov. 19, 2020 and updated

david
Review Board
release-3.0.x
reviewboard

In some cases, the cleartool executable may be in an unusual location,
have an alternate name, or users may want to use a wrapper script of
some sort. This change adds an optional settings key to allow people to
set the location or name of cleartool.

Ran unit tests.

Summary
Make cleartool location configurable.
Description From Last Updated

E501 line too long (83 > 79 characters)

reviewbotreviewbot

E303 too many blank lines (2)

reviewbotreviewbot

F811 redefinition of unused 'test_get_cleartool_custom' from line 27

reviewbotreviewbot

E303 too many blank lines (2)

reviewbotreviewbot

Can we define a new named logger in this file? That'll provide some context.

chipx86chipx86

I'm not 100% sure that this will do the right thing if it's an absolute path. I think we just ...

chipx86chipx86
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

david
Review request changed

Commits:

Summary
-
Make cleartool location configurable.
+
Make cleartool location configurable.

Diff:

Revision 2 (+152 -14)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

david
Review request changed

Change Summary:

Actually commit all files.

Commits:

Summary
-
Make cleartool location configurable.
+
Make cleartool location configurable.

Diff:

Revision 3 (+150 -14)

Show changes

Checks run (2 succeeded)

flake8 passed.
JSHint passed.
chipx86
  1. 
      
  2. reviewboard/scmtools/clearcase.py (Diff revision 3)
     
     

    Can we define a new named logger in this file? That'll provide some context.

    1. I'm going to do that in a later change.

  3. reviewboard/scmtools/clearcase.py (Diff revision 3)
     
     

    I'm not 100% sure that this will do the right thing if it's an absolute path. I think we just look for the binary in the path. Can you check?

    1. is_exe_in_path works correctly when passed in an absolute path.

  4. 
      
chipx86
  1. Ship It!
  2. 
      
Loading...