Slack Integration with OAuth 2.0

Review Request #11289 — Created Nov. 19, 2020 and updated — Latest diff uploaded

Information

rbintegrations
master

Reviewers

Slack Integration workflow now uses OAuth 2.0.
Users fill out the form with the credentials provided
by Slack App and clicks on a button Authorize to bring
up the OAuth 2.0 popup workflow.

  • Manually tested adding Slack integration using OAuth 2.0 workflow
    • Access token is successfully saved into config
    • Slack integration successfully sends notifications to
      linked channel
      with a test Slack App set up
  • Ran unit tests, all works except 2 needing image attachments:
    • test_notify_new_review_request_with_image_file_attachment
    • test_notify_updated_review_request_with_new_image_attachments

Changes between revision 5 and 6

orig
1
2
3
4
5
6
7
8
9
10

Commits

Summary ID Author
Slack Integration with OAuth 2.0
8f46c0b5c1bd05adbbb76050bb62ce26030cc2be ruonan
Slack Integration with OAuth 2.0
8552d8c96243566bb93e7ac72e3b12130e2f5420 ruonan
Slack Integration with OAuth 2.0
778441228f7713bc2254d8d22cecf8c19ed39484 ruonan
rbintegrations/static/js/slack/authorize.js
Loading...