Slack Integration with OAuth 2.0

Review Request #11289 — Created Nov. 19, 2020 and updated — Latest diff uploaded

Information

rbintegrations
master

Reviewers

Slack Integration workflow now uses OAuth 2.0.
Users fill out the form with the credentials provided
by Slack App and clicks on a button Authorize to bring
up the OAuth 2.0 popup workflow.

  • Manually tested adding Slack integration using OAuth 2.0 workflow
    • Access token is successfully saved into config
    • Slack integration successfully sends notifications to
      linked channel
      with a test Slack App set up
  • Ran unit tests, all works except 2 needing image attachments:
    • test_notify_new_review_request_with_image_file_attachment
    • test_notify_updated_review_request_with_new_image_attachments

Changes between revision 1 and 2

orig
1
2
3
4
5
6
7
8
9
10

Commits

Summary ID Author
Slack Integration with OAuth 2.0
0acc9d0a86aa177e34b9f2d7a6afb854291f3a78 ruonan
Slack Integration with OAuth 2.0
383a156e8fae540c36d8141839d32339440e988d ruonan
Slack Integration with OAuth 2.0
a1d2c37223634394941b0313e47d5cbe1a1a031f ruonan
rbintegrations/slack/forms.py
rbintegrations/slack/tests.py
Loading...