• 
      

    Fix execution of JavaScript unit tests on Review Board 4.0.

    Review Request #11286 — Created Nov. 17, 2020 and submitted

    Information

    Review Board
    release-4.0.x

    Reviewers

    At some point, our JavaScript unit test suite regressed, due to some
    execution order issue. The settings we wanted to apply to Jasmine
    weren't taking effect, and this wrecked havoc on most of our test suite.

    This seems to be due to our attempt to apply these settings on document
    ready. This wasn't actually executing when it needed to. Now, as of this
    change, we're just applying them immediately. Since this JavaScript
    block executes after everything else has loaded, and doesn't depend on
    any part of the DOM, it wasn't necessary to wait.

    With this change, all JavaScript unit tests pass.

    All unit tests pass.

    Verified with a clear cache.

    Summary ID
    Fix execution of JavaScript unit tests on Review Board 4.0.
    At some point, our JavaScript unit test suite regressed, due to some execution order issue. The settings we wanted to apply to Jasmine weren't taking effect, and this wrecked havoc on most of our test suite. This seems to be due to our attempt to apply these settings on document ready. This wasn't actually executing when it needed to. Now, as of this change, we're just applying them immediately. Since this JavaScript block executes after everything else has loaded, and doesn't depend on any part of the DOM, it wasn't necessary to wait. With this change, all JavaScript unit tests pass.
    01c4ebec1fb450939f8dab2f19e35e8a56121b94
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to master (5ab2358)