Add support for Python 3.9.

 






 

 


  Review Request #11271
  —
  Created Nov. 9, 2020 and submitted 

 




















 

  

   Information

  





 
 

  chipx86
 









 
 

  Review Board
 









 
 

  release-4.0.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
This updates a few pieces of code to fix up compatibility with Python

3.9. This consisted of a deprecated method use

(HTMLParser.unescape()) and some code that passed a byte string into

urlopen().


Since Python 3 support is now official, the package-level checks to

enable it only if the $RB_PY3_HAS_NO_OFFICIAL_SUPPORT variable is set

have been removed, and package metadata has been updated appropriately.

 








  


 
 

  
Unit tests pass for all versions of Python.


Verified that I could build packages on Python 2 and 3.

 







 









 





  

 


 
 

  



 

  
   


    Summary
    ID

   

  
  

   


    

     

      Add support for Python 3.9.
      
This updates a few pieces of code to fix up compatibility with Python
3.9. This consisted of a deprecated method use
(`HTMLParser.unescape()`) and some code that passed a byte string into
`urlopen()`.

Since Python 3 support is now official, the package-level checks to
enable it only if the `$RB_PY3_HAS_NO_OFFICIAL_SUPPORT` variable is set
have been removed, and package metadata has been updated appropriately.

     


    		
    9801fdbf97fa7d9c3b549551ef5f9dcbbe91cfa5

   



  
 




 













 






 
 
 

  

   

    

     
    

    
    
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
    

   

   

    
     

      Description
      From
      Last Updated
     

    
    



     

      
       
       
E126 continuation line over-indented for hanging indent

      		
      
       reviewbotreviewbot
      
      
       
      
     


    
   

  

 







 






  

 



















 




 

  


   

   

    
 
Checks run (1 failed, 1 succeeded)


    
   


  

  

  





 

 flake8
 failed.
 





 

 JSHint
 passed.
 













 
flake8

 


 










  

 





 














 





 

  

   




david




   

   







  

 



 

  


   

   

    
 
david


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Once Review Bot is happy, I am too.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




chipx86




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  







  

   

    Status:
   

   


    Completed

   

  




  

   

    Change Summary:
   

   

    
Pushed to release-4.0.x (0d8950d)