Can you adjust the Description and Testing Done to be <= 76 columns?

It looks like your changes for the start indexes wound up in here. Can you rebase on top of that …

E231 missing whitespace after ','

E231 missing whitespace after ','

F821 undefined name 'csv'

E302 expected 2 blank lines, found 1

F821 undefined name 'os'

E261 at least two spaces before inline comment

F821 undefined name 'argparse'

E501 line too long (80 > 79 characters)

E501 line too long (84 > 79 characters)

E231 missing whitespace after ','

E501 line too long (107 > 79 characters)

F821 undefined name 'get_filenames'

F821 undefined name 'read_input'

F821 undefined name 'find_match'

F821 undefined name 'rm_duplicate'

E231 missing whitespace after ','

E265 block comment should start with '# '

W293 blank line contains whitespace

E226 missing whitespace around arithmetic operator

E231 missing whitespace after ','

E305 expected 2 blank lines after class or function definition, found 1

E231 missing whitespace after ','

E231 missing whitespace after ','

F821 undefined name 'csv'

W293 blank line contains whitespace

E303 too many blank lines (3)

F821 undefined name 'os'

E261 at least two spaces before inline comment

F821 undefined name 'argparse'

E501 line too long (80 > 79 characters)

E231 missing whitespace after ','

E231 missing whitespace after ','

F821 undefined name 'csv'

E302 expected 2 blank lines, found 1

F821 undefined name 'os'

E261 at least two spaces before inline comment

F821 undefined name 'argparse'

E501 line too long (80 > 79 characters)

E501 line too long (84 > 79 characters)

E231 missing whitespace after ','

E501 line too long (107 > 79 characters)

F821 undefined name 'get_filenames'

F821 undefined name 'read_input'

F821 undefined name 'find_match'

F821 undefined name 'rm_duplicate'

E231 missing whitespace after ','

E265 block comment should start with '# '

W293 blank line contains whitespace

E226 missing whitespace around arithmetic operator

E231 missing whitespace after ','

E305 expected 2 blank lines after class or function definition, found 1

E231 missing whitespace after ','

E231 missing whitespace after ','

F821 undefined name 'csv'

W293 blank line contains whitespace

E303 too many blank lines (3)

F821 undefined name 'os'

E261 at least two spaces before inline comment

F821 undefined name 'argparse'

E501 line too long (80 > 79 characters)

E231 missing whitespace after ','

E231 missing whitespace after ','

F821 undefined name 'csv'

E302 expected 2 blank lines, found 1

F821 undefined name 'os'

E261 at least two spaces before inline comment

F821 undefined name 'argparse'

E501 line too long (80 > 79 characters)

E501 line too long (84 > 79 characters)

E231 missing whitespace after ','

E501 line too long (107 > 79 characters)

F821 undefined name 'get_filenames'

F821 undefined name 'read_input'

F821 undefined name 'find_match'

F821 undefined name 'rm_duplicate'

E231 missing whitespace after ','

E265 block comment should start with '# '

W293 blank line contains whitespace

E226 missing whitespace around arithmetic operator

E231 missing whitespace after ','

E305 expected 2 blank lines after class or function definition, found 1

E231 missing whitespace after ','

E231 missing whitespace after ','

F821 undefined name 'csv'

W293 blank line contains whitespace

E303 too many blank lines (3)

F821 undefined name 'os'

E261 at least two spaces before inline comment

F821 undefined name 'argparse'

E501 line too long (80 > 79 characters)

E231 missing whitespace after ','

E231 missing whitespace after ','

F821 undefined name 'csv'

E302 expected 2 blank lines, found 1

F821 undefined name 'os'

E261 at least two spaces before inline comment

E501 line too long (80 > 79 characters)

F821 undefined name 'argparse'

E501 line too long (84 > 79 characters)

E231 missing whitespace after ','

E501 line too long (107 > 79 characters)

F821 undefined name 'get_filenames'

F821 undefined name 'read_input'

F821 undefined name 'find_match'

F821 undefined name 'rm_duplicate'

E231 missing whitespace after ','

E265 block comment should start with '# '

W293 blank line contains whitespace

E226 missing whitespace around arithmetic operator

E231 missing whitespace after ','

E305 expected 2 blank lines after class or function definition, found 1

E231 missing whitespace after ','

E231 missing whitespace after ','

F821 undefined name 'csv'

W293 blank line contains whitespace

E303 too many blank lines (3)

F821 undefined name 'os'

E261 at least two spaces before inline comment

F821 undefined name 'argparse'

E501 line too long (80 > 79 characters)

E231 missing whitespace after ','

E231 missing whitespace after ','

F821 undefined name 'csv'

E302 expected 2 blank lines, found 1

F821 undefined name 'os'

E261 at least two spaces before inline comment

F821 undefined name 'argparse'

E501 line too long (80 > 79 characters)

E501 line too long (84 > 79 characters)

E231 missing whitespace after ','

E501 line too long (107 > 79 characters)

F821 undefined name 'get_filenames'

F821 undefined name 'read_input'

F821 undefined name 'find_match'

F821 undefined name 'rm_duplicate'

E231 missing whitespace after ','

E265 block comment should start with '# '

W293 blank line contains whitespace

E226 missing whitespace around arithmetic operator

E231 missing whitespace after ','

E305 expected 2 blank lines after class or function definition, found 1

E231 missing whitespace after ','

E231 missing whitespace after ','

F821 undefined name 'csv'

W293 blank line contains whitespace

E303 too many blank lines (3)

F821 undefined name 'os'

E261 at least two spaces before inline comment

F821 undefined name 'argparse'

E501 line too long (80 > 79 characters)

F401 'reviewboard.diffviewer.differ.DiffCompatVersion' imported but unused

E226 missing whitespace around arithmetic operator

E226 missing whitespace around arithmetic operator

E226 missing whitespace around arithmetic operator

E231 missing whitespace after ','

E231 missing whitespace after ','

E226 missing whitespace around arithmetic operator

E226 missing whitespace around arithmetic operator

E226 missing whitespace around arithmetic operator

E226 missing whitespace around arithmetic operator

E226 missing whitespace around arithmetic operator

E226 missing whitespace around arithmetic operator

E226 missing whitespace around arithmetic operator

E303 too many blank lines (2)

E226 missing whitespace around arithmetic operator

E231 missing whitespace after ','

E231 missing whitespace after ','

E231 missing whitespace after ','

E226 missing whitespace around arithmetic operator

E231 missing whitespace after ','

E128 continuation line under-indented for visual indent

E226 missing whitespace around arithmetic operator

E231 missing whitespace after ','

E226 missing whitespace around arithmetic operator

E231 missing whitespace after ','

E226 missing whitespace around arithmetic operator

E231 missing whitespace after ','

E231 missing whitespace after ','

E226 missing whitespace around arithmetic operator

E226 missing whitespace around arithmetic operator

E226 missing whitespace around arithmetic operator

E226 missing whitespace around arithmetic operator

E128 continuation line under-indented for visual indent

E226 missing whitespace around arithmetic operator

E226 missing whitespace around arithmetic operator

E226 missing whitespace around arithmetic operator

E226 missing whitespace around arithmetic operator

E226 missing whitespace around arithmetic operator

E231 missing whitespace after ','

Can you add a file-level docstring above this? (Blank line separating it from this import.)

No blank line here.

This needs to subclass object. Also, this should probably be outside of the PatienceDiffer class.

The trailing """ can go on the first line.

Blank line between a class-level docstring and the body.

This is missing a docstring describing the arguments.

These would all go into an Attributes: section in the class's docstring (to deal with parsability issues).

"Return whether ..." Same below.

Type goes on its own line. It also needs to be bool (casing matters). Same comments below.

This can be a single statement, since the conditional evaluates to true or false. Same below.

How about: "Return a string representation of this slice."

The type must be unicode

So normally, this should be formatted like: return ( 'A: %s\n' 'B: %s\n' '%s' % ((self.a_low, self.a_high), (self.b_low, self.b_high), '-' …

If this doesn't need to perform any logic of its own, you can omit it.

Summary docstrings cannot wrap. How about: """Return an opcode generator for the contents of the diff.

This should just be tuple, with the contents described in the description.

For readability, can you use keyword arguments? That'll help convey what's going into this class without having to jump up …

There should be a blank line separating a statement from a block on the same indentation level, but not on …

Let's store as a tuple. It'll take less memory and will be faster to operate on, which is preferred here.

"Differ" -> "Diff"

The description must be on the next line, indented 4. Rather than describe the opcode format, you can just say …

Same as above.

Blank line between these.

As mentioned above, slice is a reserved word.

"Return all ..."

Description on the next line.

Description gets its own lines.

Because you use range, you'll need to a six.moves import for range. Grep in the codebase for import range and …

Bcause we use self.a and self.b a lot, let's pull these out into local variables to avoid the attribute lookup …

A couple notes here: When we have an if/else, it's a bit easier mentally work with if the first condition …

Comments need to always be proper sentences, so this should have a period.

It doesn't look like we use this for anything else. Can we just reference i?

No blank line here.

Let's avoid all the lookups and instead iterate using six.iteritems, which will give us keys and values.

"If"

This can be one statement.

This must be a single line.

Same comments as above regarding the formatting.

No blank line here.

Rather than separate elif lines with comments separating them, put the comments inside the nested block. That will keep the …

No blank line at the start of a nested block.

Must use sentence casing.

Rather than have to compare to stacks[-1] each time, let's fetch the value of stacks[-1] once and then compare against …

Rather than single-line code, which is harder to reason about and maintain, can you split this up as: prev = …

while True:

This needs sentence casing.

We can just check if not prev here, which will be faster (as it uses a different operator).

No blank line at the start of a nested block.

Same doc comments as above. I'll let you handle the rest :)

Rather than the shorthand, can you set these individually? It's more clear and maintainable that way.

Blank line between these.

Rather than look up match[1] for each iteration, let's pull it out above.

Rather than looking up matched_slices[-1] each time, let's pull it out into a last_matched_slice variable and access that.

Blank line before a statement opening a new block.

Can you use parens? Like: while (not slice.is_empty() and self.a[slice.a_low] == self.b[slice.b_low]): Also, let's fetch self.a and self.b to avoid …

With this conditional, we're returning slice either way. This code can be cleaned up by doing: if old_a_low != slice.a_low: …

This can be one statement.

Much of my comments in match_head apply here as well.

Can you add a file-level docstring?

"PatienceDiffer"

""" goes on the next line.

Can you add a docstring for this?

E127 continuation line over-indented for visual indent

E127 continuation line over-indented for visual indent

E127 continuation line over-indented for visual indent

E231 missing whitespace after ','

E127 continuation line over-indented for visual indent

E127 continuation line over-indented for visual indent

E502 the backslash is redundant between brackets

E127 continuation line over-indented for visual indent